Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got missed in #453. Since
_queuedReadData
is never written to,CheckOldKeyDecryptedData()
will always return -1.There may be an opportunity to simplify locking but for now, I only removed useless function and preserved
ThrowIfExceptionalOrNotAuthenticated
logic.I also check 3.x code and
_queuedReadData
is only updated byEnqueueOldKeyDecryptedData
. But since_pendingReHandshake
is never set, that code is also effectively dead.