Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Arm64] Implement ASIMD Extract Insert ExtractVector64 ExtractVector128 #35030

Merged
merged 53 commits into from
Apr 22, 2020
Merged

[Arm64] Implement ASIMD Extract Insert ExtractVector64 ExtractVector128 #35030

merged 53 commits into from
Apr 22, 2020

Commits on Apr 9, 2020

  1. Put ExtractAndNarrowLow after ExtractAndNarrowHigh in AdvSimd.cs AdvS… 

    …imd.PlatformNotSupported.cs
    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    14bdaf1 View commit details
    Browse the repository at this point in the history

  2. Add Extract in AdvSimd.cs AdvSimd.PlatformNotSupported.cs

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    dfcf01f View commit details
    Browse the repository at this point in the history

  3. Add Insert in AdvSimd.cs AdvSimd.PlatformNotSupported.cs

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    74b4868 View commit details
    Browse the repository at this point in the history

  4. Add ExtractVector64 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    803e2f5 View commit details
    Browse the repository at this point in the history

  5. Add ExtractVector128 in AdvSimd.cs AdvSimd.PlatformNotSupported.cs

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b1852ad View commit details
    Browse the repository at this point in the history

  6. Update System.Runtime.Intrinsics.Experimental.cs

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    8cec295 View commit details
    Browse the repository at this point in the history

  7. Update Helpers.cs Helpers.tt

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    648ee20 View commit details
    Browse the repository at this point in the history

  8. Add ExtractTest.template

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    6b4fbed View commit details
    Browse the repository at this point in the history

  9. Add ExtractVectorTest.template

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    9a82b44 View commit details
    Browse the repository at this point in the history

  10. Add InsertTest.template

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1fcbade View commit details
    Browse the repository at this point in the history

  11. Add Extract in GenerateTests.csx

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    bf58686 View commit details
    Browse the repository at this point in the history

  12. Add ExtractVector64 and ExtractVector128 in GenerateTests.csx

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    34eccf3 View commit details
    Browse the repository at this point in the history

  13. Add Insert in GenerateTests.csx

    @echesakov
    echesakov committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    7effe2a View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Put ExtractAndNarrowLow after ExtractAndNarrowHigh in GenerateTests.csx

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    c5673aa View commit details
    Browse the repository at this point in the history

  2. Update AdvSimd/ AdvSimd.Arm64/

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    6aaaa41 View commit details
    Browse the repository at this point in the history

  3. Add emitter unit tests for INS_ext in codegenarm64.cpp

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    6953bb2 View commit details
    Browse the repository at this point in the history

  4. Implement INS_ext in emitarm64.cpp emitfmtsarm64.h instrsarm64.h

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    f75ab71 View commit details
    Browse the repository at this point in the history

  5. Update hwintrinsiclistarm64.h

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    233c348 View commit details
    Browse the repository at this point in the history

  6. Formatting in instrsarm64.h

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    8246181 View commit details
    Browse the repository at this point in the history

  7. Remove HWIntrinsicInfo::ival on Arm64 in hwintrinsic.cpp hwintrinsic.… 

    …h hwintrinsiclistarm64.h namedintrinsiclist.h valuenumfuncs.h
    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    9f3c72e View commit details
    Browse the repository at this point in the history

  8. Remove lookupImmUpperBound on Arm64 in hwintrinsic.h hwintrinsicarm64… 

    ….cpp
    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    36d4e96 View commit details
    Browse the repository at this point in the history

  9. Remove HW_Flag_NoContainment and add HW_Flag_SupportsContainment in h… 

    …wintrinsic.h hwintrinsiclistarm64.h
    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    7d87daa View commit details
    Browse the repository at this point in the history

  10. Remove HWIntrinsic in hwintrinsiccodegenarm64.cpp

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    23c1b94 View commit details
    Browse the repository at this point in the history

  11. Add HWIntrinsic in hwintrinsic.h

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    0d82dcd View commit details
    Browse the repository at this point in the history

  12. Remove #include-s in hwintrinsiccodegenarm64.cpp

    @echesakov
    echesakov committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    563c3e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Add analysis for allocation of branchTargetReg in lsraarm64.cpp

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    6843309 View commit details
    Browse the repository at this point in the history

  2. Add ContainmentAnalysis for ASIMD Extract in lowerarmarch.cpp

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    62ec8a5 View commit details
    Browse the repository at this point in the history

  3. Add ContainmentAnalysis for ASIMD ExtractVector64 and ExtractVector12… 

    …8 in lowerarmarch.cpp
    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    e75ed7f View commit details
    Browse the repository at this point in the history

  4. Add ContainmentAnalysis for ASIMD Insert in lowerarmarch.cpp

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    1cc6804 View commit details
    Browse the repository at this point in the history

  5. Add HWIntrinsicImmOpHelper in codegen.h hwintrinsiccodegenarm64.cpp

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    991ae92 View commit details
    Browse the repository at this point in the history

  6. Add ASIMD Extract in hwintrinsiccodegenarm64.cpp

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    78ceca9 View commit details
    Browse the repository at this point in the history

  7. Add ASIMD ExtractVector64 and ExtractVector128 in hwintrinsiccodegena… 

    …rm64.cpp
    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    59b73ae View commit details
    Browse the repository at this point in the history

  8. Add ASIMD Insert in hwintrinsiccodegenarm64.cpp

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    e254782 View commit details
    Browse the repository at this point in the history

  9. Remove isInImmRange in hwintrinsic.cpp hwintrinsic.h

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    4b71324 View commit details
    Browse the repository at this point in the history

  10. Remove redundant #ifdef-#endif FEATURE_HW_INTRINSICS in hwintrinsic.cpp

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    9fa5b54 View commit details
    Browse the repository at this point in the history

  11. Remove TYP_lastIntrins in vartype.h

    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    c29c46d View commit details
    Browse the repository at this point in the history

  12. Remove unused call to HWIntrinsicInfo::lookupCategory in Compiler::ge… 

    …tBaseTypeFromArgIfNeeded in hwintrinsic.cpp
    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    a82f248 View commit details
    Browse the repository at this point in the history

  13. Implement HWIntrinsicInfo::lookupImmUpperBound on Arm64 in hwintrinsi… 

    …c.h hwintrinsicarm64.cpp
    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    d732e2d View commit details
    Browse the repository at this point in the history

  14. Pass immUpperBound explicitely in addRangeCheckIfNeeded in compiler.h… 

    … hwintrinsic.cpp
    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    ed72d41 View commit details
    Browse the repository at this point in the history

  15. Refactor logic to check an immediate operand and support Arm64 intrin… 

    …sics in hwintrinsic.cpp
    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    9471dc3 View commit details
    Browse the repository at this point in the history

  16. Add missing . between className and methodName in Compiler::lookupNam… 

    …edIntrinsic in importer.cpp
    @echesakov
    echesakov committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    29d87b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Re-refactor impHWIntrinsic in hwintrinsic.cpp

    @echesakov
    echesakov committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c2416a0 View commit details
    Browse the repository at this point in the history

  2. Has HWIntrinsicInfo::isInImmRange accept unnecessary arguments on x86… 

    … to avoid ifdef-s at places where this function is used in hwintrinsic.h hwintrinsicarm64.cpp hwintrinsicxarch.cpp
    @echesakov
    echesakov committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    a12ed8d View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Remove Extract methods that operate on 64x1_t types in AdvSimd.cs Adv… 

    …Simd.PlatformNotSupported.cs
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    2436d51 View commit details
    Browse the repository at this point in the history

  2. Remove Insert methods that operate on 64x1_t types in AdvSimd.cs AdvS… 

    …imd.PlatformNotSupported.cs
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    2b710cc View commit details
    Browse the repository at this point in the history

  3. Update System.Runtime.Intrinsics.Experimental.cs

    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    19394b0 View commit details
    Browse the repository at this point in the history

  4. Update comment for Compiler::getArgForHWIntrinsic in hwintrinsic.cpp

    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    532a9f4 View commit details
    Browse the repository at this point in the history

  5. Add comment and rename elemType->baseType in HWIntrinsicInfo::lookupI… 

    …mmUpperBound in hwintrinsicarm64.cpp
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    347b2c8 View commit details
    Browse the repository at this point in the history

  6. Rename EmitAtFirst->EmitBegin and EmitAfterCase->EmitCaseEnd in CodeG… 

    …en::HWIntrinsicImmOpHelper in hwintrinsiccodegenarm64.cpp
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    02892e4 View commit details
    Browse the repository at this point in the history

  7. Rename BranchAtNonZero->TestImmOpZeroOrOne in CodeGen::HWIntrinsicImm… 

    …OpHelper in hwintrinsiccodegenarm64.cpp
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    7fc1c43 View commit details
    Browse the repository at this point in the history

  8. Document HWIntrinsicImmOpHelper class and how it should be used in co… 

    …degen.h and hwintrinsiccodegenarm64.cpp
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    6ba615f View commit details
    Browse the repository at this point in the history

  9. Make more flags in HWIntrinsicFlag platform-specific and re-order the… 

    …m with update their values in hwintrinsic.h
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    65ca881 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into Arm64-ASIMD-Extract-Insert-ExtractVector64… 

    …-ExtractVector128
    @echesakov
    echesakov committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    b0bcb43 View commit details
    Browse the repository at this point in the history