Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test ALPN detection #36928

Merged
merged 4 commits into from
May 27, 2020
Merged

Improve test ALPN detection #36928

merged 4 commits into from
May 27, 2020

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented May 23, 2020

PlatformDetection made assumption that Linux = !Windowns && !OSX. That breaks runs on iOS.
This improves TLS13 & ALPN detection. with this.

 Xcode: /Users/furt/github/wfurt-runtime/artifacts/bin/System.Net.WebClient.Tests/net5.0-Debug/ios-x64/AppBundle/System.Net.WebClient.Tests/System.Net.WebClient.Tests.xcodeproj
  App: /Users/furt/github/wfurt-runtime/artifacts/bin/System.Net.WebClient.Tests/net5.0-Debug/ios-x64/AppBundle/System.Net.WebClient.Tests/Release-iphonesimulator/System.Net.WebClient.Tests.app
  XHarness command issued: ios test --app=/Users/furt/github/wfurt-runtime/artifacts/bin/System.Net.WebClient.Tests/net5.0-Debug/ios-x64/AppBundle/System.Net.WebClient.Tests/Release-iphonesimulator/System.Net.WebClient.Tests.app --targets=ios-simulator-64 --output-directory=/Users/furt/github/wfurt-runtime/artifacts/bin/System.Net.WebClient.Tests/net5.0-Debug/ios-x64/AppBundle/xharness-output
  info: test[0]
        Starting test for ios-simulator-64..
  info: test[0]
        Starting application 'System.Net.WebClient.Tests' on ios-simulator-64
  info: test[0]
        Application finished the test run successfully
  info: test[0]
        Tests run: 36 Passed: 36 Inconclusive: 0 Failed: 0 Ignored: 0
  XHarness exit code: 0
  Xharness artifacts: /Users/furt/github/wfurt-runtime/artifacts/bin/System.Net.WebClient.Tests/net5.0-Debug/ios-x64/AppBundle/xharness-output

contributes to #36890

@ghost
Copy link

ghost commented May 23, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@wfurt wfurt requested review from mdh1418 and a team May 23, 2020 19:45
@davidsh davidsh added this to the 5.0 milestone May 23, 2020
@jaredpar jaredpar mentioned this pull request May 25, 2020
Closed
mdh1418
mdh1418 reviewed May 26, 2020
View reviewed changes
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated Show resolved Hide resolved
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
{
// Covers Linux and FreeBSD
return OpenSslVersion >= new Version(1,1,1);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove extra line

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Show resolved Hide resolved
@wfurt wfurt merged commit b42753b into dotnet:master May 27, 2020
@wfurt wfurt deleted the ios_36890 branch May 27, 2020 16:35
@mdh1418 mdh1418 mentioned this pull request Jun 9, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdh1418 mdh1418 mdh1418 left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

@stephentoub stephentoub stephentoub approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@wfurt @akoeplinger @stephentoub @ViktorHofer @mdh1418 @davidsh @Dotnet-GitSync-Bot