Remove ClearInitLocalsAssemblies arg #37355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See dotnet/linker#1237. Setting the boolean ClearInitLocals is sufficient here because we are only linking the target assembly. If in the future we need to control it per-assembly, we can use metadata on AssemblyPaths: https://github.com/mono/linker/blob/master/src/ILLink.Tasks/LinkTask.cs#L23
|
Tagging subscribers to this area: @ViktorHofer |
stephentoub
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
LGTM as long as you've double and triple checked that the binaries we're producing still have the flag removed appropriately. 😄 Thanks. (Subsequently, it'd be great to switch to the C# 9 feature to avoid the flag in the first place rather than relying on the linker removing it.)
|
I've double-checked. Will triple-check. :) |
#35527 is assigned so hopefully it will be completed soon |
marek-safar
approved these changes
Jun 3, 2020
erozenfeld
approved these changes
Jun 3, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/linker#1237.
Setting the boolean ClearInitLocals is sufficient here because we are
only linking the target assembly. If in the future we need to control
it per-assembly, we can use metadata on AssemblyPaths:
https://github.com/mono/linker/blob/master/src/ILLink.Tasks/LinkTask.cs#L23