Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ilverify fixes #37388

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Ilverify fixes #37388

merged 3 commits into from
Jun 4, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jun 4, 2020

No description provided.

@ghost
Copy link

ghost commented Jun 4, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

Copy link
Contributor

@jashook jashook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you for working on this.

<Link>TypeSystem\Common\TypeSystemConstraintsHelpers.cs</Link>
</Compile>
</ItemGroup>
<Import Project="ILVerification.projitems" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to open this correctly in VS, you'll need to add a .shproj just how we do with System.Private.CoreLib:

https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.shproj

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do I get by doing that? As far as I can tell, the current VS is perfectly happy without it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it show all the cs files? Maybe it is just needed for different subtrees. I don't recall why we needed to do it for S.P.CoreLib. @ViktorHofer do you remember?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it show all the cs files?

Yes: image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then disregard my comment. I’ll let @ViktorHofer explain why it was needed for S.P.CoreLib.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the shproj for CoreLib was necessary as the projitems file is located in a different directory tree. VS refused to load without it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, so then I did remember sort of correctly after @jkotas told me it worked fine. Thanks @ViktorHofer for solving the mystery 😄

@jashook
Copy link
Contributor

jashook commented Jun 4, 2020

@jashook jashook mentioned this pull request Jun 4, 2020
@jkotas jkotas merged commit 9e3aaa7 into dotnet:master Jun 4, 2020
@jkotas jkotas deleted the ilverify-fixes branch June 4, 2020 18:32
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants