-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ilverify fixes #37388
Ilverify fixes #37388
Conversation
Tagging subscribers to this area: @ViktorHofer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thank you for working on this.
<Link>TypeSystem\Common\TypeSystemConstraintsHelpers.cs</Link> | ||
</Compile> | ||
</ItemGroup> | ||
<Import Project="ILVerification.projitems" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to open this correctly in VS, you'll need to add a .shproj just how we do with System.Private.CoreLib:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do I get by doing that? As far as I can tell, the current VS is perfectly happy without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it show all the cs files? Maybe it is just needed for different subtrees. I don't recall why we needed to do it for S.P.CoreLib. @ViktorHofer do you remember?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then disregard my comment. I’ll let @ViktorHofer explain why it was needed for S.P.CoreLib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the shproj for CoreLib was necessary as the projitems file is located in a different directory tree. VS refused to load without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, so then I did remember sort of correctly after @jkotas told me it worked fine. Thanks @ViktorHofer for solving the mystery 😄
No description provided.