Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix System.Net.Http build break #38341

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Fix System.Net.Http build break #38341

merged 1 commit into from
Jun 24, 2020

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Jun 24, 2020 •
edited
Loading

#34948 broke the build. It conflicted with #37619 which was merged yesterday.

cc: @ManickaP, @davidsh

@ghost
Copy link

ghost commented Jun 24, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@ManickaP
Copy link
Member

ManickaP commented Jun 24, 2020 •
edited
Loading

I'm looking at it right now.
Edit: I just realized that this is a PR and not an issue 🤦 So thanks for fixing it.

ManickaP
ManickaP approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@stephentoub stephentoub merged commit a7f2f43 into dotnet:master Jun 24, 2020
@stephentoub stephentoub deleted the fixhttpbreak branch June 24, 2020 15:48
@davidsh
Copy link
Contributor

davidsh commented Jun 24, 2020

It conflicted with #37619 which was merged yesterday.

Sorry for the conflict. Thanks for fixing it so fast! :)

@davidsh davidsh added this to the 5.0.0 milestone Jun 24, 2020
@stephentoub
Copy link
Member Author

Thanks for fixing it so fast! :)

Self-serving ;-)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManickaP ManickaP ManickaP approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @ManickaP @davidsh @Dotnet-GitSync-Bot