Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement CertificateAssetDownloader.DownloadAsset with HttpClient.Send #38502

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

stephentoub
Copy link
Member

@ghost
Copy link

ghost commented Jun 28, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@stephentoub stephentoub reopened this Jun 29, 2020
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not an expert in Crypto code base.

@stephentoub stephentoub merged commit e21a14b into dotnet:master Jun 29, 2020
@stephentoub stephentoub deleted the x509send branch June 29, 2020 16:10
@ManickaP ManickaP mentioned this pull request Jul 2, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CertificateAssetDownloader should be updated to use HttpClient.Send
5 participants