Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoreLib path resolution #39921

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Fix CoreLib path resolution #39921

merged 1 commit into from
Jul 25, 2020

Conversation

ViktorHofer
Copy link
Member

Fixes issue described in #39891 (comment).

@ViktorHofer ViktorHofer requested a review from safern July 25, 2020 11:38
@ghost
Copy link

ghost commented Jul 25, 2020

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

safern
safern approved these changes Jul 25, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ViktorHofer ViktorHofer merged commit b77b242 into master Jul 25, 2020
@safern safern deleted the ViktorHofer-corelibwasm branch July 25, 2020 20:06
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@ViktorHofer @Jacksondr5
Fix CoreLib path resolution (dotnet#39921)
ceae69c 
Fixes issue described in dotnet#39891 (comment).
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
area-Infrastructure-mono
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ViktorHofer @safern @karelz @jkotas @Dotnet-GitSync-Bot