Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small ref PR in preparation for arm64 apple work. #42270

Merged
merged 4 commits into from
Sep 19, 2020

Conversation

sandreenko
Copy link
Contributor

@sandreenko sandreenko commented Sep 15, 2020

Some small refactorings that I need in future changes:

5fd98a3d831: Mark some getters as const to avoid build errors.

1cc69bcf3d9: use gtGetStructHandle if NO_CLASS_HANDLE means an error.

29902f91653: Add GetStructHnd to LclVarDsc.

A small contribution to #32648.

cebee101cf2: additional asserts.

It is a zero diff change (after #42343 and #42320).

@sandreenko sandreenko added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 15, 2020
@sandreenko sandreenko force-pushed the Arm64Apple-Jit-Part1 branch 2 times, most recently from 8cceab2 to cebee10 Compare September 16, 2020 23:04
@sandreenko
Copy link
Contributor Author

PTAL @dotnet/jit-contrib

Copy link
Contributor

@jashook jashook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandreenko sandreenko merged commit 1905238 into dotnet:master Sep 19, 2020
@sandreenko sandreenko deleted the Arm64Apple-Jit-Part1 branch September 20, 2020 11:31
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants