Adds support for building Wasm on Windows #45545

steveisok · 2020-12-03T14:18:52Z

Emscripten and EMSDK_PATH must be set up externally. This differs from linux and macos where we optionally can do it for you.

steveisok · 2020-12-03T14:22:12Z

@lewing @akoeplinger Thoughts on where this should build on CI?

eng/native/gen-buildsys.cmd

jkotas · 2020-12-03T14:48:31Z

cc @yowl

src/libraries/Native/build-native.cmd

src/mono/mono.proj

src/mono/wasm/wasm.proj

lewing · 2020-12-11T21:40:46Z

/cc @radical

jkotas · 2020-12-13T18:02:34Z

Thoughts on where this should build on CI?

We would need to get a Windows machine with Emscripten. The easiest way to do that is to install Emscripten on the fly. https://github.com/dotnet/runtimelab/blob/d0cda961aeda26faae17c474e26d822cd1e45438/eng/pipelines/runtimelab/install-emscripten.cmd is a small script to do that. I am not sure whether it would be appropriate for dotnet/runtime CI though.

akoeplinger · 2020-12-14T11:18:18Z

Thoughts on where this should build on CI?

I think we'll mostly want to protect the Windows wasm build for local developer purposes, official builds will likely always use Linux so to me this would make it a good fit for the runtime-live-build pipeline.

I'm not a big fan of introducing the on the fly download of Emscripten like you do in the runtimelab since it's another dependency that can break dotnet/runtime CI.

steveisok · 2020-12-14T12:13:26Z

Thoughts on where this should build on CI?

I think we'll mostly want to protect the Windows wasm build for local developer purposes, official builds will likely always use Linux so to me this would make it a good fit for the runtime-live-build pipeline.

I'm not a big fan of introducing the on the fly download of Emscripten like you do in the runtimelab since it's another dependency that can break dotnet/runtime CI.

Agreed re: not downloading emscripten every time.

@lewing @radical Do you see the need to run tests? Or will only build validation suffice?

… build works on windows

radical · 2021-03-16T01:24:09Z

src/mono/wasm/wasm.proj

@@ -110,4 +108,109 @@
          SkipUnchangedFiles="true" />
  </Target>

+  <UsingTask TaskName="GenerateWasmVersionFile"
+    AssemblyFile="$(WasmBuildTasksAssemblyPath)"/>
+  <Target Name="BuildWinWasmRuntimes"


Can this target replace the make invocation in BuildWasmRuntimes? I mean, are they two effectively the same?

src/mono/wasm/wasm.proj

src/mono/mono.proj

Similar to what we do in build.sh

To avoid this error: Installing tool 'node-12.18.1-64bit'.. Installation failed! Error: Downloading URL 'https://storage.googleapis.com/webassembly/emscripten-releases-builds/deps/node-v12.18.1-win-x64.zip': <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1045)> Warning: Possibly SSL/TLS issue. Update or install Python SSL root certificates (2048-bit or greater) supplied in Python folder or https://pypi.org/project/certifi/ and try again. Warning: The SDK/tool 'node-12.18.1-64bit' cannot be activated since it is not installed! Skipping this tool... The script comes from runtimelabs repo https://github.com/dotnet/runtimelab/blob/d0cda961aeda26faae17c474e26d822cd1e45438/eng/pipelines/runtimelab/update-machine-certs.ps1

And use it in Makefile and mono.proj

radical · 2021-03-16T17:23:44Z

@lewing @radical Do you see the need to run tests? Or will only build validation suffice?

IMHO, for this PR, build validation should be enough. That should enable more of us to try this out, and tests can be enabled in a follow up PR.

I think we are missing cmake and failing with: configure: cmake -DENABLE_WERROR=1 -DCMAKE_INSTALL_PREFIX=D:\workspace\_work\1\s\artifacts\obj\mono\Browser.wasm.Debug\out -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_BUILD_TYPE=Debug -DGC_SUSPEND=preemptive -DENABLE_MINIMAL=jit,portability,sgen_major_marksweep_conc,sgen_split_nursery,sgen_gc_bridge,sgen_toggleref,sgen_debug_helpers,sgen_binary_protocol,logging,shared_perfcounters,interpreter,threads,eventpipe,qcalls -DENABLE_INTERP_LIB=1 -DDISABLE_ICALL_TABLES=1 -DDISABLE_CRASH_REPORTING=1 -DENABLE_ICALL_EXPORT=1 -DENABLE_LAZY_GC_THREAD_CREATION=1 -DENABLE_LLVM_RUNTIME=1 -DENABLE_METADATA_UPDATE=1 "-DCMAKE_C_FLAGS= -fexceptions -ID:\workspace\_work\1\s\.packages\microsoft.netcore.runtime.icu.transport\6.0.0-preview.3.21151.1/runtimes/browser-wasm/native/include" "-DCMAKE_CXX_FLAGS= -fexceptions" D:\workspace\_work\1\s\src\mono\ -DCMAKE_TOOLCHAIN_FILE=D:\workspace\_work\1\s\src\mono\wasm\emsdk\upstream\emscripten\cmake\Modules\Platform\Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR="D:/workspace/_work/1/s/src/mono/wasm/emsdk/node/12.18.1_64bit/bin/node.exe" -G Ninja Traceback (most recent call last): File "D:\workspace\_work\1\s\src\mono\wasm\emsdk\upstream\emscripten\\emcmake.py", line 33, in <module> sys.exit(run()) File "D:\workspace\_work\1\s\src\mono\wasm\emsdk\upstream\emscripten\\emcmake.py", line 26, in run building.configure(sys.argv[1:]) File "D:\workspace\_work\1\s\src\mono\wasm\emsdk\upstream\emscripten\tools\building.py", line 339, in configure run_process(args, stdout=stdout, stderr=stderr, env=env, **kwargs) File "D:\workspace\_work\1\s\src\mono\wasm\emsdk\upstream\emscripten\tools\shared.py", line 94, in run_process ret = subprocess.run(cmd, check=check, input=input, *args, **kw) File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\subprocess.py", line 472, in run File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\subprocess.py", line 775, in __init__ File "D:\obj\windows-release\37amd64_Release\msi_python\zip_amd64\subprocess.py", line 1178, in _execute_child FileNotFoundError: [WinError 2] The system cannot find the file specified D:\workspace\_work\1\s\src\mono\mono.proj(410,5): error MSB3073: The command "call D:\workspace\_work\1\s\src\mono\wasm\emsdk\emsdk_env.bat && emcmake cmake -DENABLE_WERROR=1 -DCMAKE_INSTALL_PREFIX=D:\workspace\_work\1\s\artifacts\obj\mono\Browser.wasm.Debug\out -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_BUILD_TYPE=Debug -DGC_SUSPEND=preemptive -DENABLE_MINIMAL=jit,portability,sgen_major_marksweep_conc,sgen_split_nursery,sgen_gc_bridge,sgen_toggleref,sgen_debug_helpers,sgen_binary_protocol,logging,shared_perfcounters,interpreter,threads,eventpipe,qcalls -DENABLE_INTERP_LIB=1 -DDISABLE_ICALL_TABLES=1 -DDISABLE_CRASH_REPORTING=1 -DENABLE_ICALL_EXPORT=1 -DENABLE_LAZY_GC_THREAD_CREATION=1 -DENABLE_LLVM_RUNTIME=1 -DENABLE_METADATA_UPDATE=1 -DCMAKE_C_FLAGS=" -fexceptions -ID:\workspace\_work\1\s\.packages\microsoft.netcore.runtime.icu.transport\6.0.0-preview.3.21151.1/runtimes/browser-wasm/native/include" -DCMAKE_CXX_FLAGS=" -fexceptions" D:\workspace\_work\1\s\src\mono\" exited with code 1. ##[error]src\mono\mono.proj(410,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command "call D:\workspace\_work\1\s\src\mono\wasm\emsdk\emsdk_env.bat && emcmake cmake -DENABLE_WERROR=1 -DCMAKE_INSTALL_PREFIX=D:\workspace\_work\1\s\artifacts\obj\mono\Browser.wasm.Debug\out -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_BUILD_TYPE=Debug -DGC_SUSPEND=preemptive -DENABLE_MINIMAL=jit,portability,sgen_major_marksweep_conc,sgen_split_nursery,sgen_gc_bridge,sgen_toggleref,sgen_debug_helpers,sgen_binary_protocol,logging,shared_perfcounters,interpreter,threads,eventpipe,qcalls -DENABLE_INTERP_LIB=1 -DDISABLE_ICALL_TABLES=1 -DDISABLE_CRASH_REPORTING=1 -DENABLE_ICALL_EXPORT=1 -DENABLE_LAZY_GC_THREAD_CREATION=1 -DENABLE_LLVM_RUNTIME=1 -DENABLE_METADATA_UPDATE=1 -DCMAKE_C_FLAGS=" -fexceptions -ID:\workspace\_work\1\s\.packages\microsoft.netcore.runtime.icu.transport\6.0.0-preview.3.21151.1/runtimes/browser-wasm/native/include" -DCMAKE_CXX_FLAGS=" -fexceptions" D:\workspace\_work\1\s\src\mono\" exited with code 1.

This reverts commit bd95f34.

ivan-prodanov · 2021-03-16T21:00:55Z

Can't wait to use this. 👀

To try if it helps with the cmake issue

Also revert emscripten version back

This reverts commit b1c4da1.

radical

Looks good. There are some issues like it breaks if the runtime checkout is in a path with spaces, but we can fix those in a follow up PR. CI doesn't have the same issue.

ivan-prodanov · 2021-03-17T16:25:01Z

Great job everyone!
Do we have an example on how to build AOT Wasm apps on windows?

src/mono/mono.proj

src/mono/wasm/Makefile

akoeplinger · 2021-03-17T16:33:55Z

eng/pipelines/runtime-staging.yml

+    jobParameters:
+      testGroup: innerloop
+      nameSuffix: Browser_wasm_Windows
+      buildArgs: -subset mono+libs /p:RuntimeFlavor=Mono


given that it's the runtime-staging pipeline this is probably fine temporarily but for regular runs we need to take another look since right now this clones emsdk and downloads binaries from google storage on each PR which is something we generally want to avoid.

yes, looking forward to use the nuget instead

lewing · 2021-03-17T16:37:49Z

@ivan-prodanov we have few more pieces to get into place first but we will be documenting the process soon.

marek-safar · 2021-03-17T17:19:42Z

src/mono/mono.proj

@@ -360,11 +386,12 @@
    </ItemGroup>

    <PropertyGroup>
-      <_MonoCMakeConfigureCommand>cmake @(_MonoCMakeArgs, ' ') $(MonoCMakeExtraArgs) $(MonoProjectRoot)</_MonoCMakeConfigureCommand>
+      <_MonoCMakeConfigureCommand>cmake @(_MonoCMakeArgs, ' ') $(MonoCMakeExtraArgs) $(MonoProjectRoot.TrimEnd('\/'))</_MonoCMakeConfigureCommand>


isn't there some msbuild magic function for this?

I didn't find any. There are functions that do the opposite - make sure that there is trailing slash. @radical do you know if there's better way to do this?

Steve Pfister added 2 commits December 2, 2020 12:17

First pass at building wasm on windows

3d0b7e3

Adds support for building wasm on Windows

0c1ec30

Emscripten and EMSDK_PATH must be set up externally. This differs from linux and macos where we optionally can do it for you.

steveisok requested review from akoeplinger, EgorBo, marek-safar and vargaz as code owners December 3, 2020 14:18

Dotnet-GitSync-Bot added the area-Build-mono label Dec 3, 2020

steveisok changed the title ~~Adds support for building wasm on Windows~~ Adds support for building Wasm on Windows Dec 3, 2020

steveisok requested a review from lewing December 3, 2020 14:22

jkotas reviewed Dec 3, 2020

View reviewed changes

eng/native/gen-buildsys.cmd Outdated Show resolved Hide resolved

jkotas reviewed Dec 3, 2020

View reviewed changes

src/libraries/Native/build-native.cmd Outdated Show resolved Hide resolved

Cleanup

be23653

runfoapp bot mentioned this pull request Dec 3, 2020

Bundle_extraction_is_reused intermittently fails with "text file is busy" #44657

Closed

akoeplinger reviewed Dec 3, 2020

View reviewed changes

src/mono/mono.proj Outdated Show resolved Hide resolved

src/mono/wasm/wasm.proj Outdated Show resolved Hide resolved

src/mono/wasm/wasm.proj Show resolved Hide resolved

Steve Pfister added 2 commits December 4, 2020 14:43

Feedback

18b23b3

Rename conflicting target

49a4881

akoeplinger mentioned this pull request Dec 10, 2020

[WASM] AOT compilation on Windows #45657

Closed

lewing added the arch-wasm WebAssembly architecture label Dec 11, 2020

jkotas mentioned this pull request Dec 20, 2020

Make testing wasm on windows in runtimelab easier by using MSBuild IsOSPlatform not TargetOS #46105

Closed

Steve Pfister added 3 commits January 20, 2021 13:55

Merge remote-tracking branch 'upstream/master' into wasm-windows-build

4e25a46

Made sure current master still works

293a72d

auto provision when EMSDK_PATH is not set and try to see if a browser…

3994d5b

… build works on windows

Base automatically changed from master to main March 1, 2021 09:07

Add call in front of batch scripts. All of a sudden it's necessary

dd80db7

radical reviewed Mar 16, 2021

View reviewed changes

radekdoulik added 6 commits March 16, 2021 14:38

Use RunWithEmSdkEnv task

f749d71

Override arch for Browser OS

73ded7d

Similar to what we do in build.sh

Merge remote-tracking branch 'upstream/main' into wasm-windows-build

255df25

Use msbuild to write the emcc version file

e4ef34d

Put emscripten version in text file

41fcc10

And use it in Makefile and mono.proj

radekdoulik added 4 commits March 16, 2021 19:07

Try to fix Browser_wasm_Windows detection

0de7128

Try use newer cmake

bd95f34

Revert "Try use newer cmake"

cf864f1

This reverts commit bd95f34.

radekdoulik added 8 commits March 16, 2021 22:33

Normalize path

58a31f9

Remove excessive space char

b1c4da1

Try newer emscripten version

920c59b

To try if it helps with the cmake issue

Try trim end '\' from directory passed to cmake

ed9a82b

Also revert emscripten version back

Provision emscripten only when targeting wasm

cde3a23

Do not set $os, it is already set above

11cd9bc

Revert "Remove excessive space char"

460fcf7

This reverts commit b1c4da1.

Provision emscripten only on windows

e732a35

radical approved these changes Mar 17, 2021

View reviewed changes

radekdoulik merged commit 4ae9b33 into dotnet:main Mar 17, 2021

akoeplinger reviewed Mar 17, 2021

View reviewed changes

marek-safar reviewed Mar 17, 2021

View reviewed changes

akoeplinger deleted the wasm-windows-build branch March 22, 2021 16:24

ghost locked as resolved and limited conversation to collaborators Apr 21, 2021

karelz added this to the 6.0.0 milestone May 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for building Wasm on Windows #45545

Adds support for building Wasm on Windows #45545

steveisok commented Dec 3, 2020

steveisok commented Dec 3, 2020

jkotas commented Dec 3, 2020

lewing commented Dec 11, 2020 •

edited

Loading

jkotas commented Dec 13, 2020

akoeplinger commented Dec 14, 2020 •

edited

Loading

steveisok commented Dec 14, 2020

radical Mar 16, 2021

steveisok Mar 16, 2021

radical commented Mar 16, 2021

ivan-prodanov commented Mar 16, 2021

radical left a comment

ivan-prodanov commented Mar 17, 2021 •

edited

Loading

akoeplinger Mar 17, 2021

radekdoulik Mar 17, 2021

lewing commented Mar 17, 2021

marek-safar Mar 17, 2021

radekdoulik Mar 17, 2021

Adds support for building Wasm on Windows #45545

Adds support for building Wasm on Windows #45545

Conversation

steveisok commented Dec 3, 2020

steveisok commented Dec 3, 2020

jkotas commented Dec 3, 2020

lewing commented Dec 11, 2020 • edited Loading

jkotas commented Dec 13, 2020

akoeplinger commented Dec 14, 2020 • edited Loading

steveisok commented Dec 14, 2020

radical Mar 16, 2021

Choose a reason for hiding this comment

steveisok Mar 16, 2021

Choose a reason for hiding this comment

radical commented Mar 16, 2021

ivan-prodanov commented Mar 16, 2021

radical left a comment

Choose a reason for hiding this comment

ivan-prodanov commented Mar 17, 2021 • edited Loading

akoeplinger Mar 17, 2021

Choose a reason for hiding this comment

radekdoulik Mar 17, 2021

Choose a reason for hiding this comment

lewing commented Mar 17, 2021

marek-safar Mar 17, 2021

Choose a reason for hiding this comment

radekdoulik Mar 17, 2021

Choose a reason for hiding this comment

lewing commented Dec 11, 2020 •

edited

Loading

akoeplinger commented Dec 14, 2020 •

edited

Loading

ivan-prodanov commented Mar 17, 2021 •

edited

Loading