Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventSource linker warnings fix #46510

Merged
merged 15 commits into from
Jan 7, 2021
Merged

EventSource linker warnings fix #46510

merged 15 commits into from
Jan 7, 2021

Conversation

LakshanF
Copy link
Member

@LakshanF LakshanF commented Jan 2, 2021

First set of changes for EventSource trim warnings. This is a WIP that fixes EventSource.cs warnings with other fixes to come

@ghost
Copy link

ghost commented Jan 2, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

First set of changes for EventSource trim warnings. This is a WIP that fixes EventSource.cs warnings with other fixes to come

Author: LakshanF
Assignees: -
Labels:

area-System.Diagnostics.Tracing
Milestone: -

@LakshanF LakshanF mentioned this pull request Jan 2, 2021
Merged
@runfoapp runfoapp bot mentioned this pull request Jan 4, 2021
Closed
@runfoapp runfoapp bot mentioned this pull request Jan 4, 2021
Closed
@eerhardt eerhardt added the linkable-framework Issues associated with delivering a linker friendly framework label Jan 4, 2021
@ghost
Copy link

ghost commented Jan 4, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF
See info in area-owners.md if you want to be subscribed.

Issue Details

First set of changes for EventSource trim warnings. This is a WIP that fixes EventSource.cs warnings with other fixes to come

Author: LakshanF
Assignees: -
Labels:

area-System.Diagnostics.Tracing, linkable-framework
Milestone: -

@MichalStrehovsky MichalStrehovsky mentioned this pull request Jan 6, 2021
Closed
eerhardt
eerhardt approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LakshanF LakshanF merged commit 9538bee into dotnet:master Jan 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2021
@LakshanF LakshanF deleted the LibWrnEventSrc branch May 10, 2022 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@vitek-karas vitek-karas vitek-karas approved these changes

@stephentoub stephentoub stephentoub left review comments

@eerhardt eerhardt eerhardt approved these changes

@tlakollo tlakollo Awaiting requested review from tlakollo

@sywhang sywhang Awaiting requested review from sywhang

Assignees
No one assigned
Labels
area-System.Diagnostics.Tracing linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LakshanF @stephentoub @eerhardt @vitek-karas @MichalStrehovsky @AaronRobinsonMSFT @Dotnet-GitSync-Bot