Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uses of uninitialized data #46965

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Fix uses of uninitialized data #46965

merged 3 commits into from
Jan 15, 2021

Conversation

BruceForstall
Copy link
Member

Fixes #46961

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 14, 2021
@BruceForstall
Copy link
Member Author

@AndyAyersMS PTAL
cc @dotnet/jit-contrib

danmoseley
danmoseley reviewed Jan 14, 2021
View reviewed changes
src/coreclr/jit/flowgraph.cpp Outdated
{
BasicBlock* returnBlock = returnBlocks[i];
// Check the returnBlocks[] first, so we don't access an uninitialized
// returnContants[] value (which some tools like valgrind will
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@BruceForstall BruceForstall merged commit e3247ad into dotnet:master Jan 15, 2021
@BruceForstall BruceForstall deleted the FixUninitVarUsage branch January 15, 2021 00:04
@ghost ghost locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JIT: some jumps based on uninitialized values detected by valgrind
3 participants
@BruceForstall @danmoseley @AndyAyersMS