[wasm] fix invariant linking error

[lewing]

Disable the conditional inclusion to fix #48847 until we have a solution.

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Disable the conditional inclusion to fix #48847 until we have a solution.

Author:	lewing
Assignees:	-
Labels:	arch-wasm, area-Build-mono, size-reduction
Milestone:	-

[lewing]

cc @CoffeeFlux

[directhex]

To confirm, this is the fix for:

        [stdout]   error: undefined symbol: u_errorName (referenced by top-level compiled C/C++ code)
        [stdout]   error: undefined symbol: udata_setCommonData (referenced by top-level compiled C/C++ code)
        [stdout]   error: undefined symbol: ulocdata_getCLDRVersion (referenced by top-level compiled C/C++ code)

?

[lewing]

To confirm, this is the fix for:

        [stdout]   error: undefined symbol: u_errorName (referenced by top-level compiled C/C++ code)
        [stdout]   error: undefined symbol: udata_setCommonData (referenced by top-level compiled C/C++ code)
        [stdout]   error: undefined symbol: ulocdata_getCLDRVersion (referenced by top-level compiled C/C++ code)

?

yes

[vargaz]

Adding these files to the link line is actually not increasing the size of the final executable if its not used, so it looks harmless.

[lewing]

Would reopen #43689 I verified the symbols are linked out when they aren't referenced

[lewing]

The errors is because the symbols are still reachable somehow, this will fix that problem. When the symbols are unreachable they get properly removed without this so it does no good. #49499

[eerhardt]

It would be nice to put a link to what "the linking issue" is here, so if someone reads this they know what it is talking about.

[lewing]

I verified the code is linked out when the build is correct so forcing them to be conditional here is only an optimization. #49499 is the issue tracking what might be breaking the build in CI.

[steveisok]

Android device legs are backed up. Rest of the runs look good.