Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AndroidCrypto] Fix remaining Algorithms test failures. #49501

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

jkoritzinsky
Copy link
Member

Product fixes:

  • Return a different error code for curve-not-supported to correctly throw PNSE.

Test fixes:

  • Allow platforms that support explicit curves to indicate they support a particular curve when parameters are supplied explicitly but not by name
  • Split the DSA tests by key size for easy disabling on Android.
  • Disable a few tests that won't pass on Android (some of which are disabled on other platforms).

@ghost
Copy link

ghost commented Mar 11, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Product fixes:

  • Return a different error code for curve-not-supported to correctly throw PNSE.

Test fixes:

  • Allow platforms that support explicit curves to indicate they support a particular curve when parameters are supplied explicitly but not by name
  • Split the DSA tests by key size for easy disabling on Android.
  • Disable a few tests that won't pass on Android (some of which are disabled on other platforms).
Author: jkoritzinsky
Assignees: -
Labels:

area-System.Security, os-android

Milestone: 6.0.0

…med variant or when that platform has differing support (Android) and supports explicit curves.
@jkoritzinsky jkoritzinsky merged commit 707b903 into dotnet:main Mar 16, 2021
@jkoritzinsky jkoritzinsky deleted the ecc-test-fixes branch March 16, 2021 21:47
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants