Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arcade packaging workaround #49613

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Remove arcade packaging workaround #49613

merged 1 commit into from
Mar 18, 2021

Conversation

ViktorHofer
Copy link
Member

No description provided.

@ViktorHofer ViktorHofer requested a review from Anipik March 14, 2021 22:05
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer
Copy link
Member Author

@steveisok @akoeplinger there are tons of Mono crashes on Desktop configurations. Are these known?

@ghost
Copy link

ghost commented Mar 15, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@steveisok
Copy link
Member

steveisok commented Mar 15, 2021

Yes, it looks like the ones I've asked @directhex to handle.

#49569 (comment)

@ViktorHofer
Copy link
Member Author

Thanks. The Linux is a different one?

~/work/BAC009CA/w/B5ED09A6/e ~/work/BAC009CA/w/B5ED09A6/e
  Discovering: System.Threading.Thread.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Threading.Thread.Tests (found 43 of 49 test cases)
  Starting:    System.Threading.Thread.Tests (parallel test collections = on, max threads = 2)
    System.Threading.Threads.Tests.ThreadTests.ApartmentState_NoAttributePresent_DefaultState_Nano [SKIP]
      Condition(s) not met: "IsWindowsNanoServerAndRemoteExecutorSupported"
    System.Threading.Threads.Tests.ThreadTests.ApartmentStateTest_ChangeBeforeThreadStarted_Windows_Nano_Server [SKIP]
      Condition(s) not met: "IsWindowsNanoServer"
  Finished:    System.Threading.Thread.Tests
=== TEST EXECUTION SUMMARY ===
   System.Threading.Thread.Tests  Total: 53, Errors: 0, Failed: 0, Skipped: 2, Time: 2.128s

Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
   at System.Threading.WaitSubsystem.OnThreadExiting(Thread thread) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/WaitSubsystem.Unix.cs:line 430
   at System.Threading.Thread.Finalize() in /_/src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs:line 85
[ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object
   at System.Threading.WaitSubsystem.OnThreadExiting(Thread thread) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/WaitSubsystem.Unix.cs:line 430
   at System.Threading.Thread.Finalize() in /_/src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs:line 85
~/work/BAC009CA/w/B5ED09A6/e

@steveisok
Copy link
Member

@CoffeeFlux ^^

@CoffeeFlux
Copy link
Contributor

That one should have been fixed with #49628

@ViktorHofer ViktorHofer merged commit 2f2113e into main Mar 18, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch March 18, 2021 14:29
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants