Move NonDisposedSocket_SafeHandlesCollected to a non-parallel test collection #50279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAttempt to fix #50068. The hang/timeout happens in While this might be a sign of a product bug in unlucky case, it's orthogonal to what /cc @geoffkizer @wfurt
|
stephentoub
approved these changes
Mar 26, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #50068.
The hang/timeout happens in
CreateHandlesAsync(clientAsync : true), which means we have trouble creating 100 connected socket pairs asynchronously on the CI machines, while running all the other tests in parallel.While this might be a sign of a product bug in unlucky case, it's orthogonal to what
NonDisposedSocket_SafeHandlesCollectedis testing. I recommend to open a separate issue for theCreateHandlesAsynctimeout after/if this PR is merged./cc @geoffkizer @wfurt