Switch to ProjectExclusions for assembly-level ActiveIssue tests on browser #50891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsUse With the assembly-level
|
elinor-fung
force-pushed
the
browserTestExclusions
branch
from
dd01b61
to
af4d010
Compare
steveisok
approved these changes
Apr 8, 2021
This was referenced Apr 8, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ProjectExclusionsitems for libraries tests that were markedActiveIssue(..., TestPlatforms.Browser)on the assembly level for browser (mostly crypto-related for #37669).With the assembly-level
ActiveIssue, the tests are still built / packaged and sent to run on helix machines - which goes through test discovery for all test cases, finds that none of them should be run (so it passes), and uploads test results/artifacts. Switching toProjectExclusionsavoids this unnecessary usage of resources.