Expose Adjustment Rule BaseUtcOffsetDelta #51055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
4 tasks
|
CC @gewarren for the doc part. |
stephentoub
reviewed
Apr 12, 2021
| @@ -2314,7 +2314,7 @@ public static IEnumerable<object[]> SystemTimeZonesTestData() | |||
| for (int i = -14; i <= 12; i++) | |||
| { | |||
| TimeZoneInfo tz = null; | |||
|
|
|||
| try | |||
| { | |||
| string id = $"Etc/GMT{i:+0;-0}"; | |||
There was a problem hiding this comment.
This formatting is going to be subject to the current culture, which could impact the negative sign used. Is that going to be an issue for someone running the tests in, say, Sweden?
There was a problem hiding this comment.
It is possible to fail. As this is not related to this PR, we can address that in another PR.
In reply to: 611643769 [](ancestors = 611643769)
stephentoub
approved these changes
Apr 12, 2021
gewarren
reviewed
Apr 12, 2021
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
|
LGTM |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50256