Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify file allocation size #51111

Merged
merged 42 commits into from
May 18, 2021
Merged

Allow to specify file allocation size #51111

merged 42 commits into from
May 18, 2021

Commits on Apr 12, 2021

  1. add the new ctor to the ref assembly

    @adamsitnik
    adamsitnik committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    fe24ee2 View commit details
    Browse the repository at this point in the history

  2. add tests

    @adamsitnik
    adamsitnik committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c127580 View commit details
    Browse the repository at this point in the history

  3. add new ctor

    @adamsitnik
    adamsitnik committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    f3af047 View commit details
    Browse the repository at this point in the history

  4. initial Windows implementation

    @adamsitnik
    adamsitnik committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    5d004fd View commit details
    Browse the repository at this point in the history

  5. fix the build

    @adamsitnik
    adamsitnik committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    bbac6d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. remove duplicated Interop code

    @adamsitnik
    adamsitnik committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    5451439 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into fileAllocationSize 

    # Conflicts:
#	src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs
    @adamsitnik
    adamsitnik committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    29b1223 View commit details
    Browse the repository at this point in the history

  3. fix the full framework build

    @adamsitnik
    adamsitnik committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    07cfc75 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. initial Unix implementation

    @adamsitnik
    adamsitnik committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    945c917 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into fileAllocationSize

    @adamsitnik
    adamsitnik committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    0b566aa View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. some polishing

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    3bf1f95 View commit details
    Browse the repository at this point in the history

  2. remove unused using and extra empty lines from existing tests

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    ed1f18d View commit details
    Browse the repository at this point in the history

  3. the active issue link should point to a valid issue

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    f645e67 View commit details
    Browse the repository at this point in the history

  4. the tests should actually verify whether FileStream is async or not

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    909c86e View commit details
    Browse the repository at this point in the history

  5. remove duplicated consts

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    6789382 View commit details
    Browse the repository at this point in the history

  6. proper tests for Windows

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    dbe44d4 View commit details
    Browse the repository at this point in the history

  7. implement Unix tests and make them pass by moving fallocate call afte… 

    …r lock and after truncate
    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    3571a23 View commit details
    Browse the repository at this point in the history

  8. fix the Windows build...

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    cbe2277 View commit details
    Browse the repository at this point in the history

  9. align macOS implementation with Linux

    @adamsitnik
    adamsitnik committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    c490439 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. polishing

    @adamsitnik
    adamsitnik committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    7842eba View commit details
    Browse the repository at this point in the history

  2. handle files that are too large for the current file system

    @adamsitnik
    adamsitnik committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    b2cc9f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. add a test for "file was too large" exception

    @adamsitnik
    adamsitnik committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ed5808f View commit details
    Browse the repository at this point in the history

  2. and handling for EFBIG

    @adamsitnik
    adamsitnik committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e250d96 View commit details
    Browse the repository at this point in the history

  3. fix the Unix build

    @adamsitnik
    adamsitnik committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    df155e2 View commit details
    Browse the repository at this point in the history

  4. fix a wrong assert

    @adamsitnik
    adamsitnik committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b6929e3 View commit details
    Browse the repository at this point in the history

  5. try to enable the new tests for Browser build

    @adamsitnik
    adamsitnik committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6875a9f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: David Cantú <[email protected]>
    @adamsitnik @carlossanlop @jozkee
    3 people committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    0a0edad View commit details
    Browse the repository at this point in the history

  2. apply other suggestions for the code review, get rid of the managed a… 

    …llocaiton of the extended path
    @adamsitnik
    adamsitnik committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    c46ac66 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into fileAllocationSize

    @adamsitnik
    adamsitnik committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    142fbb1 View commit details
    Browse the repository at this point in the history

  4. disable it for WASM

    @adamsitnik
    adamsitnik committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    83f119d View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. address code review feedback: remove unused path parameter, use stack… 

    …alloc for small inputs
    @adamsitnik
    adamsitnik committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    37b9245 View commit details
    Browse the repository at this point in the history

  2. address code review feedback: if NtCreateFile fails, we should immedi… 

    …ately throw an exception and don't call CreateFile
    @adamsitnik
    adamsitnik committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    c2f995e View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Carlos Sanchez <[email protected]>
    @adamsitnik @carlossanlop
    adamsitnik and carlossanlop committed May 14, 2021
    Configuration menu
    Copy the full SHA
    2b00680 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into fileAllocationSize 

    # Conflicts:
#	src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.Windows.cs
    @adamsitnik
    adamsitnik committed May 14, 2021
    Configuration menu
    Copy the full SHA
    60102b0 View commit details
    Browse the repository at this point in the history

  3. introduce FileStreamOptions

    @adamsitnik
    adamsitnik committed May 14, 2021
    Configuration menu
    Copy the full SHA
    4065f43 View commit details
    Browse the repository at this point in the history

  4. address code review feedback: throw ArgumentOutOfRangeException when … 

    …PreallocationSize is negative
    @adamsitnik
    adamsitnik committed May 14, 2021
    Configuration menu
    Copy the full SHA
    b0c8243 View commit details
    Browse the repository at this point in the history

  5. address code review feedback: move error codes

    @adamsitnik
    adamsitnik committed May 14, 2021
    Configuration menu
    Copy the full SHA
    2145dc1 View commit details
    Browse the repository at this point in the history

  6. SECURITY_ANONYMOUS

    @adamsitnik
    adamsitnik committed May 14, 2021
    Configuration menu
    Copy the full SHA
    5eed718 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into fileAllocationSize

    @adamsitnik
    adamsitnik committed May 14, 2021
    Configuration menu
    Copy the full SHA
    4993dbb View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. address code review feedback

    @adamsitnik
    adamsitnik committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b9987a8 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. address code review feedback and clarify which values are supported a… 

    …nd which ones throw
    @adamsitnik
    adamsitnik committed May 18, 2021
    Configuration menu
    Copy the full SHA
    9728078 View commit details
    Browse the repository at this point in the history

  2. fix XML docs

    @adamsitnik
    adamsitnik committed May 18, 2021
    Configuration menu
    Copy the full SHA
    8648f65 View commit details
    Browse the repository at this point in the history