Pass linker flags to Mono build on Android correctly #51403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were setting `_MonoLDFLAGS` in mono.proj but never passed the values down into CMake.
CoffeeFlux
approved these changes
Apr 16, 2021
|
@fanyang-mono @akoeplinger - do you have a rough idea how many tests it'll allow to pass - assuming this investigation sprung from #47850 ? |
|
This is unrelated, I just happened to notice it while looking at the project file :) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting
_MonoLDFLAGSin mono.proj but never passed the values down into CMake.