Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-revert "Fold overflow operations in value numbering" #51440

Merged
merged 24 commits into from
May 26, 2021
Merged

Re-revert "Fold overflow operations in value numbering" #51440

merged 24 commits into from
May 26, 2021

Commits on May 22, 2021

  1. Added a missing license header

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9c01c96 View commit details
    Browse the repository at this point in the history

  2. Added a test verifying that checked arithmetic is correct

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    4cafa8c View commit details
    Browse the repository at this point in the history

  3. Added a test verifying that checked casts are correct

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    96b4d20 View commit details
    Browse the repository at this point in the history

  4. Disabled the test for checked casts on Mono

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    82c460d View commit details
    Browse the repository at this point in the history

  5. Refactored VNEvalShouldFold

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    4a711aa View commit details
    Browse the repository at this point in the history

  6. Refactored gtFoldExprConst to use helpers and follow the common code … 

    …style
    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    0d18ab0 View commit details
    Browse the repository at this point in the history

  7. Fixed the comment stating TYP_BYREF has no zero value

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    0a049d6 View commit details
    Browse the repository at this point in the history

  8. Moved checking of overflow for arithmetic operations from gtFoldExprC… 

    …onst into a separate namespace
    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    10f2dcb View commit details
    Browse the repository at this point in the history

  9. Implemented folding of overflow arithmetic in value numbering

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    fa1ab87 View commit details
    Browse the repository at this point in the history

  10. Fixed some typos in valuenum.cpp/h

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9ab7753 View commit details
    Browse the repository at this point in the history

  11. Added identity-based evaluation for overflow arithmetic

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    0c66ac1 View commit details
    Browse the repository at this point in the history

  12. Made the definition of var_types a standalone header so that it can b… 

    …e safely #included'ed in utils.h
    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    c2d4d79 View commit details
    Browse the repository at this point in the history

  13. Refactored gtFoldExpr some more, moved the overflow checking logic to… 

    … CheckedOps, implemented overflow checking for floating point -> integer casts
    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9c67714 View commit details
    Browse the repository at this point in the history

  14. Implemented folding of checked casts in value numbering

    @SingleAccretion
    SingleAccretion committed May 22, 2021
    Configuration menu
    Copy the full SHA
    99a9829 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Demote the tests to Tier1 

    They throw and catch quite a few exceptions.
    @SingleAccretion
    SingleAccretion committed May 24, 2021
    Configuration menu
    Copy the full SHA
    81f9ed3 View commit details
    Browse the repository at this point in the history

  2. Fixed a comment 

    UINT32 -> UINT64
    @SingleAccretion
    SingleAccretion committed May 24, 2021
    Configuration menu
    Copy the full SHA
    4467b08 View commit details
    Browse the repository at this point in the history

  3. Made arithmetic CheckedOps functions templated 

    Reduces code duplication and obviates the need for
some conditions and casts.

They use the implementation from the Long* variants of
the old functions, except for "SubOverflows", where some
instantiations, unreachable at runtime, were using "size_t" as the
type argument and causing warnings. The relevant part of "AddOverflows"
has been inlined into "SubOverflows".
    @SingleAccretion
    SingleAccretion committed May 24, 2021
    Configuration menu
    Copy the full SHA
    59dc67f View commit details
    Browse the repository at this point in the history

  4. Move the locals under "if" to avoid shadowing

    @SingleAccretion
    SingleAccretion committed May 24, 2021
    Configuration menu
    Copy the full SHA
    0580145 View commit details
    Browse the repository at this point in the history

  5. Use ClrSafeInt instead of custom code

    @SingleAccretion
    SingleAccretion committed May 24, 2021
    Configuration menu
    Copy the full SHA
    b64e00a View commit details
    Browse the repository at this point in the history

  6. Fix a copy and paste mistake 

    Co-authored-by: Anton Lapounov <[email protected]>
    @SingleAccretion @AntonLapounov
    SingleAccretion and AntonLapounov committed May 24, 2021
    Configuration menu
    Copy the full SHA
    610b612 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Update src/coreclr/jit/utils.cpp

    @AntonLapounov
    AntonLapounov committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2982f40 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Anton Lapounov <[email protected]>
    @SingleAccretion @AntonLapounov
    SingleAccretion and AntonLapounov committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f26f1b8 View commit details
    Browse the repository at this point in the history

  3. Assert type != TYP_BYREF in VNEvalShouldFold 

    The method is not prepared to handle them.
Also add a note about that to the header.
Also delete TODO-Review about it.

Right now the only caller of VNEvalShouldFold guards against
TYP_BYREF folding, so this assert is a safety measure against
future callers not taking byrefs into account.
    @SingleAccretion
    SingleAccretion committed May 25, 2021
    Configuration menu
    Copy the full SHA
    09fc5b9 View commit details
    Browse the repository at this point in the history

  4. Drop the MAX_ prefix from MIN

    @SingleAccretion
    SingleAccretion committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ef91357 View commit details
    Browse the repository at this point in the history