Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeOnly format O #51484

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix TimeOnly format O #51484

merged 1 commit into from
Apr 19, 2021

Conversation

devsko
Copy link
Contributor

@devsko devsko commented Apr 19, 2021

Fixes #51482

cc @tarekgh

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@tarekgh
Copy link
Member

tarekgh commented Apr 19, 2021

@devsko thanks for fixing this issue. LGTM. I had it right in the code in the first place but during the code review somehow, I changed the code by mistake because of one of the comments I got.

@tarekgh tarekgh merged commit be3b593 into dotnet:main Apr 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeOnly formats milliseconds wrong with format 'o'
3 participants