Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure #51474 #51495

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix test failure #51474 #51495

merged 1 commit into from
Apr 19, 2021

Conversation

IEvangelist
Copy link
Member

There was a race condition, in which it was possible for the await host.StartAsync() to have returned before the test callbacks were invoked.

Fixes #51474

@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

There was a race condition, in which it was possible for the await host.StartAsync() to have returned before the test callbacks were invoked.

Fixes #51474

Author: IEvangelist
Assignees: -
Labels:

area-Extensions-Hosting

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming CI passes. Thanks for the quick fix here.

@ghost
Copy link

ghost commented Apr 19, 2021

Hello @eerhardt!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@eerhardt eerhardt merged commit 4bcc1c1 into main Apr 19, 2021
@eerhardt eerhardt deleted the fix-51474 branch April 19, 2021 17:23
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants