Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview4] Update dependencies from dotnet/icu #51501

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/icu

  • Subscription: c277b9d4-03c5-4bfc-8d1e-08d90058d0d8
  • Build: 20210416.1
  • Date Produced: 4/16/2021 6:59 PM
  • Commit: 313017d0effca6e8ade5fefc8e580224e65d8525
  • Branch: refs/heads/release/6.0-preview4

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 6.0.0-preview.4.21212.2 -> To Version 6.0.0-preview.4.21216.1
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mmitche
Copy link
Member

mmitche commented Apr 19, 2021

@jeffschwMSFT I've seen these failures on a few PRs. Any ideas?

@jeffschwMSFT
Copy link
Member

@agocke can you take a look, I see some apphost related failures on this PR.

@agocke
Copy link
Member

agocke commented Apr 20, 2021

Looking

@agocke
Copy link
Member

agocke commented Apr 20, 2021

@mateoatr Can you take a look? Looks like the symbolic link tests again. Can we just remove the deletion? Since the symbolic link is created in a test directory, shouldn't it be cleaned up after the test is done anyway?

@marek-safar marek-safar added the Servicing-consider Issue for next servicing release review label Apr 20, 2021
@mateoatr
Copy link
Contributor

Can we just remove the deletion? Since the symbolic link is created in a test directory, shouldn't it be cleaned up after the test is done anyway?

It should. I already removed the symlink deletion in #51373 although it's still causing problems when trying to publish the build logs in linux: #51502.

@mmitche
Copy link
Member

mmitche commented Apr 20, 2021

@mateoatr Does that need to be ported to this p4 branch?

@agocke
Copy link
Member

agocke commented Apr 20, 2021

Ugh guess symlinks can't be reliably deleted like other files. Probably need to keep the deletion then but maybe use another pinvoke to do it. Maybe call 'unlink' or 'rm' directly?

@mateoatr
Copy link
Contributor

mateoatr commented Apr 20, 2021

@mateoatr Does that need to be ported to this p4 branch?

I think it should. I already opened #51568

Probably need to keep the deletion then but maybe use another pinvoke to do it. Maybe call 'unlink' or 'rm' directly?

Yeah. I'll try unlinking; that should fix the access permissions.

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 20, 2021
@leecow leecow added this to the 6.0.0 milestone Apr 20, 2021
@agocke
Copy link
Member

agocke commented Apr 20, 2021

@mateoatr I tried File.Delete just to give it a shot.

@agocke
Copy link
Member

agocke commented Apr 21, 2021

@mmitche This is ready, I think.

@mmitche mmitche merged commit 27f3c26 into release/6.0-preview4 Apr 21, 2021
@mmitche mmitche deleted the darc-release/6.0-preview4-8037286b-2444-4604-8ce3-40c2b9b1a303 branch April 21, 2021 14:22
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2021
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants