Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Fix invoking string ctors on wasm in AOT mode. #52505

Merged
merged 2 commits into from
May 8, 2021

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented May 8, 2021

No description provided.

…kes, pass NULL instead.

The call will go to a wrapper method which will ignore the 'this' argument anyway.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@vargaz vargaz changed the title Fix invoke string ctor [mono] Fix invoking string ctors on wasm in AOT mode. May 8, 2021
@vargaz vargaz added arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test labels May 8, 2021
@ghost
Copy link

ghost commented May 8, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: vargaz
Assignees: -
Labels:

arch-wasm, wasm-aot-test

Milestone: -

@lewing lewing merged commit 607ecff into dotnet:main May 8, 2021
@vargaz vargaz deleted the fix-invoke-string-ctor branch May 8, 2021 20:41
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants