Add clrjit.natvis file #52668
Merged
Add clrjit.natvis file #52668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/jit-contrib |
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
kunalspathak
commented
May 12, 2021
BruceForstall
requested changes
May 12, 2021
src/coreclr/jit/CMakeLists.txt
Outdated
| ) | ||
|
|
||
| convert_to_absolute_path(JIT_NATVIS_SOURCE ${JIT_NATVIS_SOURCE}) | ||
| add_linker_flag("/NATVIS:${JIT_NATVIS_SOURCE}") |
There was a problem hiding this comment.
All this natvis stuff is Windows-only
There was a problem hiding this comment.
Took a stab at it. @jkoritzinsky , let me know if there is anything that is not correct.
Co-authored-by: Jeremy Koritzinsky <[email protected]>
BruceForstall
approved these changes
May 13, 2021
jkoritzinsky
approved these changes
May 14, 2021
kunalspathak
commented
May 14, 2021
| @@ -251,6 +251,10 @@ if (CLR_CMAKE_TARGET_WIN32) | |||
| vartype.h | |||
| ) | |||
|
|
|||
| # Append clrjit.natvis file | |||
| list (APPEND JIT_SOURCES | |||
| clrjit.natvis) | |||
There was a problem hiding this comment.
no, we still want it so ninja can rebuild when it changes.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
clrjit.natvisfile for better debugging experience. There are lot of things we can add to this file, but I just included the important ones that I could think of and time permitted. I have added some pattern likeLinkedListorLoopthat someone else can refer and add entries to this file for the code they work on.I am also not 100% sure of what could be useful information to display for each type of
GenTreenode, but from what I have, it should be easy to extend.Here is the sample visualizer for
jitstd::list<RefPosition>as well asRefPositionand the decomposition ofregisterAssignmentinside it to show all the registers.Unfortunately, natvis do not support typedefs or primitive types, so it will be hard to use it more broadly.