Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup internal ComWrappers cache when object enters Finalization queue #52771

Merged
merged 9 commits into from
May 25, 2021
Merged

Cleanup internal ComWrappers cache when object enters Finalization queue #52771

merged 9 commits into from
May 25, 2021

Commits on May 14, 2021

  1. Clean up the ExternalObjectContext cache for ComWrappers' RCWs.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 14, 2021
    Configuration menu
    Copy the full SHA
    21a6931 View commit details
    Browse the repository at this point in the history

  2. Add testing for verifying internal cache clean up.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 14, 2021
    Configuration menu
    Copy the full SHA
    5e344b1 View commit details
    Browse the repository at this point in the history

  3. Remove commented out tests - oops.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 14, 2021
    Configuration menu
    Copy the full SHA
    48a710b View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Merge remote-tracking branch 'upstream/main' into cleanup_cache

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 21, 2021
    Configuration menu
    Copy the full SHA
    af949b6 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Merge remote-tracking branch 'upstream/main' into cleanup_cache

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 24, 2021
    Configuration menu
    Copy the full SHA
    55d9208 View commit details
    Browse the repository at this point in the history

  2. Fix case for Disconnect logic.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5f4ac4a View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Review feedback.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d57a193 View commit details
    Browse the repository at this point in the history

  2. Review feedback.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9116b81 View commit details
    Browse the repository at this point in the history

  3. Detaching only works when inserted into the cache. Since not inserting 

    is an option remove the use of Detach in the IsActive logic and
narrow its use to the cache cleanup scenario only.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed May 25, 2021
    Configuration menu
    Copy the full SHA
    43edcb0 View commit details
    Browse the repository at this point in the history