Fix OpenSSL detection in PlatformDetection for Android #52798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsI noticed while working on the real ChaChaPoly1305 implementation for Android that the current tests are failing because it attempts to call in to the (non existing) OpenSSL shim in unit tests to check the This fixes that test bug for Android and non-macOS Apple platforms.
|
steveisok
approved these changes
May 15, 2021
filipnavara
approved these changes
May 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on the real ChaChaPoly1305 implementation for Android that the current tests are failing because it attempts to call in to the (non existing) OpenSSL shim in unit tests to check the
IsSupportedproperty.This fixes that test bug for Android and non-macOS Apple platforms.