Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch MacCatalyst interpreter runs to use AOT JustInterp #52848

Closed
wants to merge 5 commits into from

Conversation

steveisok
Copy link
Member

Since we cannot easily JIT on arm64, we need to change how we run in interp mode. The old way apparently has some JIT fallbacks, so we need to switch to the mode supported by AOT.

@ghost
Copy link

ghost commented May 17, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Since we cannot easily JIT on arm64, we need to change how we run in interp mode. The old way apparently has some JIT fallbacks, so we need to switch to the mode supported by AOT.

Author: steveisok
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@steveisok
Copy link
Member Author

As of right now, I hit an assert when running tests:

((null) error) * Assertion at /Users/steve/dev/osx-runtime/src/mono/mono/mini/aot-runtime.c:5307, condition target' not met

vargaz added a commit to vargaz/runtime that referenced this pull request May 17, 2021
We need to generate more trampolines since a lot of runtime code generates
trampolines even in --full-aot-interp mode.
Fixes dotnet#52848.
@lambdageek lambdageek reopened this May 18, 2021
@lambdageek
Copy link
Member

We need to either skip System.Diagnostics.FileVersionInfo.Tests or teach the MonoAOTCompiler task not to run on the NativeLibrary.dll file that gets copied into the publish directory. Maybe we can put some msbuild metadata on it that says "hey... i'm not a .NET .dll - don't AOT me".

This is the same issue as #46856

@lambdageek
Copy link
Member

Superceded by #53197

@lambdageek lambdageek closed this May 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants