Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reference the netstandard shim inside the shared framework #53023

Merged
merged 28 commits into from
Jun 10, 2021

Commits on May 28, 2021

  1. Don't reference ns.dll inside shared framework

    The netstandard.dll shim shouldn't be referenced inside the shared
    framework as it's a compat shim that shouldn't be required to compose
    the shared framework.
    
    This removes the necessity of a separate RefPath build and improves
    incremental build times as only the few OOB projects that require the
    shim would need to rebuild.
    ViktorHofer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    84a7872 View commit details
    Browse the repository at this point in the history
  2. Add netcoreapp2.0 config to SystemEvents

    Adding a netcoreapp2.0 configuration to SystemEvents as the source
    assembly targets netcoreapp2.0 and this avoid the netstandard shim to
    be used. The additional configuration shouldn't pose a problem as with
    an eventual convergance of reference and src projects, we will likely
    not mix universes between ref and src anymore and build the additional
    matching universe assemblies.
    ViktorHofer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    0d414d3 View commit details
    Browse the repository at this point in the history
  3. Reference netstandard shim in OOBs that require it

    There are a few OOB projects that require the netstandard.dll shim as
    they intentionally reference projects that only expose a netstandard
    configuration.
    ViktorHofer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    35497b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    15f7a63 View commit details
    Browse the repository at this point in the history
  5. Fix unix configurations

    ViktorHofer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    a245863 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    494691d View commit details
    Browse the repository at this point in the history
  7. More fixes

    ViktorHofer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    7559971 View commit details
    Browse the repository at this point in the history
  8. Add additional .NETCoreApp configurations to avoid NS shim

    Adding netcoreapp3.1 assets to libraries to avoid the
    netstandard.dll shim as a dependency. The secondary motive
    for adding these configurations is to keep source and ref
    configurations in sync to avoid weird cases where P2Ps
    resolve assets from different assembly universes depending
    on if it's a source or reference assembly.
    
    The only libraries that still go through the netstandard.dll
    shim are the Microsoft.Extensions ones.
    ViktorHofer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    86f2e60 View commit details
    Browse the repository at this point in the history
  9. Rebase errors fixed

    ViktorHofer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    b1b8c5e View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Configuration menu
    Copy the full SHA
    7526e04 View commit details
    Browse the repository at this point in the history
  2. Add one more config

    ViktorHofer committed May 31, 2021
    Configuration menu
    Copy the full SHA
    5e963d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    774f5ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c3d9f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Configuration menu
    Copy the full SHA
    f8fa9c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Configuration menu
    Copy the full SHA
    fa2d97d View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Configuration menu
    Copy the full SHA
    577c0f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4db5ecd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f5123ff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    19dd369 View commit details
    Browse the repository at this point in the history
  5. Disable failing tests

    ViktorHofer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    1b9c2db View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Apply suggestions from code review

    Co-authored-by: Buyaa Namnan <[email protected]>
    ViktorHofer and buyaa-n committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    f6175b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a65671c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    459305d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01a9ab2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2da8671 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f461ee8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3855df9 View commit details
    Browse the repository at this point in the history
  8. PR feedback

    ViktorHofer committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    120d839 View commit details
    Browse the repository at this point in the history