-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reference the netstandard shim inside the shared framework #53023
Commits on May 28, 2021
-
Don't reference ns.dll inside shared framework
The netstandard.dll shim shouldn't be referenced inside the shared framework as it's a compat shim that shouldn't be required to compose the shared framework. This removes the necessity of a separate RefPath build and improves incremental build times as only the few OOB projects that require the shim would need to rebuild.
Configuration menu - View commit details
-
Copy full SHA for 84a7872 - Browse repository at this point
Copy the full SHA 84a7872View commit details -
Add netcoreapp2.0 config to SystemEvents
Adding a netcoreapp2.0 configuration to SystemEvents as the source assembly targets netcoreapp2.0 and this avoid the netstandard shim to be used. The additional configuration shouldn't pose a problem as with an eventual convergance of reference and src projects, we will likely not mix universes between ref and src anymore and build the additional matching universe assemblies.
Configuration menu - View commit details
-
Copy full SHA for 0d414d3 - Browse repository at this point
Copy the full SHA 0d414d3View commit details -
Reference netstandard shim in OOBs that require it
There are a few OOB projects that require the netstandard.dll shim as they intentionally reference projects that only expose a netstandard configuration.
Configuration menu - View commit details
-
Copy full SHA for 35497b1 - Browse repository at this point
Copy the full SHA 35497b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15f7a63 - Browse repository at this point
Copy the full SHA 15f7a63View commit details -
Configuration menu - View commit details
-
Copy full SHA for a245863 - Browse repository at this point
Copy the full SHA a245863View commit details -
Configuration menu - View commit details
-
Copy full SHA for 494691d - Browse repository at this point
Copy the full SHA 494691dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7559971 - Browse repository at this point
Copy the full SHA 7559971View commit details -
Add additional .NETCoreApp configurations to avoid NS shim
Adding netcoreapp3.1 assets to libraries to avoid the netstandard.dll shim as a dependency. The secondary motive for adding these configurations is to keep source and ref configurations in sync to avoid weird cases where P2Ps resolve assets from different assembly universes depending on if it's a source or reference assembly. The only libraries that still go through the netstandard.dll shim are the Microsoft.Extensions ones.
Configuration menu - View commit details
-
Copy full SHA for 86f2e60 - Browse repository at this point
Copy the full SHA 86f2e60View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1b8c5e - Browse repository at this point
Copy the full SHA b1b8c5eView commit details
Commits on May 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7526e04 - Browse repository at this point
Copy the full SHA 7526e04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e963d9 - Browse repository at this point
Copy the full SHA 5e963d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 774f5ae - Browse repository at this point
Copy the full SHA 774f5aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c3d9f0 - Browse repository at this point
Copy the full SHA 2c3d9f0View commit details
Commits on Jun 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f8fa9c7 - Browse repository at this point
Copy the full SHA f8fa9c7View commit details
Commits on Jun 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fa2d97d - Browse repository at this point
Copy the full SHA fa2d97dView commit details
Commits on Jun 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 577c0f7 - Browse repository at this point
Copy the full SHA 577c0f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4db5ecd - Browse repository at this point
Copy the full SHA 4db5ecdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5123ff - Browse repository at this point
Copy the full SHA f5123ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19dd369 - Browse repository at this point
Copy the full SHA 19dd369View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b9c2db - Browse repository at this point
Copy the full SHA 1b9c2dbView commit details
Commits on Jun 10, 2021
-
Apply suggestions from code review
Co-authored-by: Buyaa Namnan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6175b8 - Browse repository at this point
Copy the full SHA f6175b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a65671c - Browse repository at this point
Copy the full SHA a65671cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 459305d - Browse repository at this point
Copy the full SHA 459305dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01a9ab2 - Browse repository at this point
Copy the full SHA 01a9ab2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2da8671 - Browse repository at this point
Copy the full SHA 2da8671View commit details -
Configuration menu - View commit details
-
Copy full SHA for f461ee8 - Browse repository at this point
Copy the full SHA f461ee8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3855df9 - Browse repository at this point
Copy the full SHA 3855df9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 120d839 - Browse repository at this point
Copy the full SHA 120d839View commit details