Remove netframework assets older than net461 from builds and packaging #53319
Conversation
Only a very few number of projects still built for net45-net46. This PR trims out these assets from the build which of course results in them not being packaged (as there is no harvesting mechanism in the repository present anymore). Suppressing the package warnings for the intentionally dropped assets and cleaning up conditions in the project file as well. For more details please see the reasoning in the linked issue. Contributes to dotnet#53282
ViktorHofer
added
area-Infrastructure-libraries
breaking-change
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsOnly a very few number of projects still built for net45-net46. Suppressing the package warnings for the intentionally dropped For more details please see the reasoning in the linked issue. Contributes to #53282
|
ghost
added
the
needs-breaking-change-doc-created
| @@ -61,12 +60,9 @@ | |||
| <Link>Common\System\LocalAppContextSwitches.Common.cs</Link> | |||
| </Compile> | |||
| </ItemGroup> | |||
| <ItemGroup Condition="'$(TargetFramework)' != 'net45'"> | |||
| <ItemGroup> | |||
| <Compile Include="System\Diagnostics\Activity.Current.net46.cs" /> | |||
There was a problem hiding this comment.
nit: should we rename this file ?
There was a problem hiding this comment.
Yes good point. Let's do that another time to not reset the PR.
ghost
locked as resolved and limited conversation to collaborators
ViktorHofer
removed
the
needs-breaking-change-doc-created
Only a very few number of projects still built for net45-net46.
This PR trims out these assets from the build which of course
results in them not being packaged (as there is no harvesting
mechanism in the repository present anymore).
Suppressing the package warnings for the intentionally dropped
assets and cleaning up conditions in the project file as well.
For more details please see the reasoning in the linked issue.
Contributes to #53282