Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove WSL checks in Socket tests #53475

Merged
merged 1 commit into from
May 30, 2021
Merged

remove WSL checks in Socket tests #53475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/ExecutionContextFlowTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public async Task APM_ExecutionContextFlowsAcrossBeginReceiveOperation(bool supp
}
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Theory]
[InlineData(false, 0)]
[InlineData(true, 0)]
[InlineData(false, 1)]
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/OSSupport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void IOControl_FIONREAD_Success()
}

[PlatformSpecific(TestPlatforms.AnyUnix)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50568", TestPlatforms.Android)]
public void IOControl_SIOCATMARK_Unix_Success()
{
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/SelectTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public void Select_Read_OneReadyAtATime(int reads)
}

[SkipOnPlatform(TestPlatforms.OSX, "typical OSX install has very low max open file descriptors value")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51392", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void Select_Error_OneReadyAtATime()
{
Expand Down
8 changes: 4 additions & 4 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceiveMisc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public void SendRecvIovMaxTcp_Success()
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
public void SendIovMaxUdp_SuccessOrMessageSize()
{
// sending more than IOV_MAX segments causes EMSGSIZE on some platforms.
Expand Down Expand Up @@ -117,7 +117,7 @@ public void SendIovMaxUdp_SuccessOrMessageSize()
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
public async Task ReceiveIovMaxUdp_SuccessOrMessageSize()
{
// receiving more than IOV_MAX segments causes EMSGSIZE on some platforms.
Expand Down Expand Up @@ -190,7 +190,7 @@ public async Task ReceiveIovMaxUdp_SuccessOrMessageSize()
await receiveTask;
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
[SkipOnPlatform(TestPlatforms.Windows, "All data is sent, even when very large (100M).")]
public void SocketSendWouldBlock_ReturnsBytesSent()
{
Expand Down Expand Up @@ -219,7 +219,7 @@ public void SocketSendWouldBlock_ReturnsBytesSent()
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)]
public async Task Socket_ReceiveFlags_Success()
{
Expand Down
10 changes: 5 additions & 5 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ public void MulticastInterface_Set_IPv6_InvalidIndex_Throws()
}
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // In WSL, the connect() call fails immediately.
[Theory]
[InlineData(false)]
[InlineData(true)]
[SkipOnPlatform(TestPlatforms.FreeBSD, "on FreeBSD Connect may or may not fail immediately based on timing.")]
Expand Down Expand Up @@ -367,7 +367,7 @@ public void ReuseAddress_Windows(bool? exclusiveAddressUse, bool? firstSocketReu
ReuseAddress(exclusiveAddressUse, firstSocketReuseAddress, secondSocketReuseAddress, expectFailure);
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Windows defaults are different
public void ExclusiveAddress_Default_Unix()
{
Expand All @@ -379,7 +379,7 @@ public void ExclusiveAddress_Default_Unix()
}
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Theory]
[InlineData(1)]
[InlineData(0)]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Unix does not have separate options for ExclusiveAddressUse and ReuseAddress.
Expand All @@ -403,7 +403,7 @@ public void SettingExclusiveAddress_SetsReuseAddress(int value)
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
public void ExclusiveAddressUseTcp()
{
using (Socket a = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp))
Expand Down Expand Up @@ -547,7 +547,7 @@ public void GetSetRawSocketOption_Roundtrips(AddressFamily family)
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52124", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void Get_AcceptConnection_Succeeds()
{
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/TcpClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ public void ExclusiveAddressUse_NullClient()
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
public void Roundtrip_ExclusiveAddressUse_GetEqualsSet_True()
{
using (TcpClient client = new TcpClient())
Expand All @@ -293,7 +293,7 @@ public void Roundtrip_ExclusiveAddressUse_GetEqualsSet_True()
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
public void Roundtrip_ExclusiveAddressUse_GetEqualsSet_False()
{
using (TcpClient client = new TcpClient())
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void Ctor_InvalidArguments_Throws()
AssertExtensions.Throws<ArgumentOutOfRangeException>("port", () => TcpListener.Create(66000));
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Theory]
[InlineData(0)]
[InlineData(1)]
[InlineData(2)]
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ public void MulticastLoopback_Roundtrips()
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")]
[Fact]
public void EnableBroadcast_Roundtrips()
{
using (var udpClient = new UdpClient())
Expand Down