Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove System.Drawing code that doesn't work #54245

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Remove System.Drawing code that doesn't work #54245

merged 1 commit into from
Jun 16, 2021

Commits on Jun 15, 2021

  1. Remove System.Drawing code that doesn't work 

    This code only runs on macOS, and expects mono's System.Windows.Forms assembly is loaded into the process. This is causing trim warnings, and it is easier just to delete this code than try to make ILLink happy.

This code is only called from Graphics.FromHwnd, which doesn't work because the Carbon.framework no longer exists on macOS. Issue dotnet#22221 is tracking the test failures that use FromHwnd.
    @eerhardt
    eerhardt committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    d74cb45 View commit details
    Browse the repository at this point in the history