Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ASAN for CoreCLR #54580

Closed
wants to merge 28 commits into from
Closed

Enable ASAN for CoreCLR #54580

wants to merge 28 commits into from

Conversation

jkoritzinsky
Copy link
Member

Enable AddressSanitizer for CoreCLR Debug and Checked build configurations instead of MSVC RTC1 runtime checks.

Fixes #52131

Contributes to #7066 (gets the infra set up that we can actually explore this)

@ghost
Copy link

ghost commented Jun 22, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Enable AddressSanitizer for CoreCLR Debug and Checked build configurations instead of MSVC RTC1 runtime checks.

Fixes #52131

Contributes to #7066 (gets the infra set up that we can actually explore this)

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@jkoritzinsky
Copy link
Member Author

Looks like due to the architecture of ASAN, we likely won't be able to run libraries tests until we make the libraries test host use the live-built hosting bits.

@ghost
Copy link

ghost commented Aug 29, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@jkoritzinsky jkoritzinsky reopened this Aug 30, 2021
@jkoritzinsky jkoritzinsky marked this pull request as ready for review August 30, 2021 17:09
@jkoritzinsky
Copy link
Member Author

Reopening as a non-draft to keep the bot from closing it.

@jkoritzinsky
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…urn addresses and other areas that ASAN doesn't like.
@AaronRobinsonMSFT
Copy link
Member

Convert to draft?

@jkoritzinsky
Copy link
Member Author

Yeah I can flip this back to draft. I just don't like when GitHub closes it due to it being a draft.

@jkoritzinsky jkoritzinsky marked this pull request as draft June 22, 2022 20:33
@ghost ghost closed this Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@RobertHenry6bev
Copy link
Contributor

Why was this closed? I'm compiling the runtime with gcc-12 -fsanitize=undefined and uncovering dozens of problems. I would clean up these errors first, then move on to tsan and asan.

@jkoritzinsky
Copy link
Member Author

This is closed because I didn't have time to get back to getting this fully working. I'll try to get the branch cleaned up and a new PR opened.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable AddressSanitizer on Debug and Checked builds for both MSVC and Clang
4 participants