Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] Enable System.Runtime.Tests #54960

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

radical
Copy link
Member

@radical radical commented Jun 30, 2021

.. this hasn't crashed in last 14 days on the tracking PR.

  • And disable the one failing test with ActiveIssue

.. this hasn't crashed in last 14 days on the tracking PR.
- And disable the one failing test with ActiveIssue
@radical radical added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue wasm-aot-test WebAssembly AOT Test labels Jun 30, 2021
@radical radical requested review from lewing and vargaz June 30, 2021 14:03
@ghost
Copy link

ghost commented Jun 30, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. this hasn't crashed in last 14 days on the tracking PR.

  • And disable the one failing test with ActiveIssue
Author: radical
Assignees: -
Labels:

arch-wasm, disabled-test, wasm-aot-test

Milestone: -

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, one question about the platform annotation

@lewing lewing merged commit 779b794 into dotnet:main Jul 1, 2021
@radical radical deleted the enable-sys-runtime-tests branch July 1, 2021 15:48
@ghost ghost locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue wasm-aot-test WebAssembly AOT Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants