Fix helloworld on x86 Linux #55095
Merged
Fix helloworld on x86 Linux #55095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
It looks like a reasonable direction to me. |
t-mustafin
force-pushed
the
fix_x86_linux_helloworld
branch
from
22834b4
to
1644a0e
Compare
t-mustafin
changed the title
|
A lot of tests on Windows x64 are failing with errors like: |
t-mustafin
force-pushed
the
fix_x86_linux_helloworld
branch
from
1644a0e
to
df48ae4
Compare
t-mustafin
force-pushed
the
fix_x86_linux_helloworld
branch
from
df48ae4
to
a6f9fcb
Compare
jkotas
reviewed
Jul 8, 2021
src/coreclr/jit/morph.cpp
Outdated
| @@ -2897,7 +2900,11 @@ void Compiler::fgInitArgInfo(GenTreeCall* call) | |||
| // Compute the maximum number of arguments that can be passed in registers. | |||
| // For X86 we handle the varargs and unmanaged calling conventions | |||
|
|
|||
| #ifdef UNIX_X86_ABI | |||
| if (call->IsVarargs()) | |||
There was a problem hiding this comment.
VarArgs is not supported on Unix, so this will be always false. Would it be better to put this whole block under #ifndef UNIX_X86_ABI ?
Make managed->managed call use of ecx, edx to pass first two arguments. Make stack alignment returning after call.
t-mustafin
force-pushed
the
fix_x86_linux_helloworld
branch
from
a6f9fcb
to
d1b6466
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on helloworld.dll x86 linux launch I've got problem during calling convention on managed call from managed code. I fixed it in morph.cpp. After that fix I had got bugs with stack misalignment. Couple of that problems I fixed in compiler.cpp and jitinterfacex86.cpp. It allows to run helloworld.dll and stack dumping with
System.Diagnostics.StackTrace. But I still have got similar stack misalignment problems on another programs.Is that fix-work direction right? Maybe I should fix managed-managed calling convention in another way?
cc @jkotas @alpencolt