Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm workload name to wasm-tools #55413

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Conversation

lewing
Copy link
Member

@lewing lewing commented Jul 9, 2021

Change microsoft-net-sdk-blazorwebassembly-aot to wasm-tools

Every other workload in the file is abstract and probably shouldn't have a short name.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lewing
Copy link
Member Author

lewing commented Jul 9, 2021

@lewing
Copy link
Member Author

lewing commented Jul 9, 2021

@joeloff throwing another feature into the mix

@lewing lewing requested a review from mhutch July 9, 2021 18:15
@lewing
Copy link
Member Author

lewing commented Jul 9, 2021

@mhutch looks like dotnet/sdk#18166 isn't in yet?

We can remove the redirect-to but there is a lot of existing tooling/instruction that uses the old name and things will break until they are updated.

@mhutch
Copy link
Member

mhutch commented Jul 9, 2021

@lewing it looks like redirects won't make it for .NET 6 as we're not 100% confident they won't have unexpected side effects as currently implemented. I think we just have to take the breaking change while we're in preview, sorry :/

@lewing
Copy link
Member Author

lewing commented Jul 9, 2021

@lewing it looks like redirects won't make it for .NET 6 as we're not 100% confident they won't have unexpected side effects as currently implemented. I think we just have to take the breaking change while we're in preview, sorry :/

It's not a problem, I was just hoping to avoid breaking the world again this week.

@lewing
Copy link
Member Author

lewing commented Jul 10, 2021

I'm going to land this later tonight unless there are strong objections.

@lewing lewing requested a review from SamMonoRT July 10, 2021 00:50
@lewing lewing merged commit f22685f into dotnet:main Jul 10, 2021
@lewing lewing deleted the wasm-rename branch July 10, 2021 01:10
@SamMonoRT
Copy link
Member

@naricc - possibly this affects the BDN Microbenchmark runs ?

@lewing lewing changed the title Update wasm workload name Update wasm workload name to wasm-tools Jul 12, 2021
@lewing lewing requested a review from mkArtakMSFT July 12, 2021 18:12
directhex added a commit to directhex/runtime that referenced this pull request Jul 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants