Ensure MeterListener.RecordObservableInstruments invoking all instruments callbacks #56183
Conversation
|
Tagging subscribers to this area: @tommcdon, @krwq Issue DetailsWhen having a MeterListener listening to multiple observable instruments and this listener is calling back all listening to instruments to collect instrumentation data; if one of the callbacks throw exception, we used to let this exception propagate. The remaining instruments callbacks will not get a chance to execute. This change is catching any exception thrown from the instrument callbacks and continue executing calling the remaining instruments. At the end of the operation, we'll throw AggregationException containing the list of all exceptions thrown during the operation.
|
tarekgh
added
area-System.Diagnostics.Metric
and removed
area-System.Diagnostics
labels
|
@noahfalk @cijothomas could you please have a look? |
…ents callbacks even some of them throw exception
tarekgh
force-pushed
the
CatchExceptionsInMetricsListenerAndThrowAggregateException
branch
from
573946b
to
1100b8d
Compare
|
The CI failure is unrelated and tracked with the issue #56190 |
tarekgh
deleted the
CatchExceptionsInMetricsListenerAndThrowAggregateException
branch
ghost
locked as resolved and limited conversation to collaborators
When having a MeterListener listening to multiple observable instruments and this listener is calling back all listening to instruments to collect instrumentation data; if one of the callbacks throw exception, we used to let this exception propagate. The remaining instruments callbacks will not get a chance to execute. This change is catching any exception thrown from the instrument callbacks and continue executing calling the remaining instruments. At the end of the operation, we'll throw AggregationException containing the list of all exceptions thrown during the operation.