Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MONO_IOMAP / portability from mono #56458

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

akoeplinger
Copy link
Member

It's not used in netcore mono (since it only works in mono but not the PAL) and judging by the discussion in #35299 the consensus is that we should not bring that feature back.

It's not used in netcore mono (since it only works in mono but not the PAL) and judging by the discussion in dotnet#35299 the consensus is that we should not bring that feature back.
@akoeplinger akoeplinger merged commit 6789379 into dotnet:main Jul 28, 2021
@akoeplinger akoeplinger deleted the remove-mono-iomap branch July 28, 2021 15:10
@cybik
Copy link

cybik commented Aug 17, 2021

Whose consensus.

@akoeplinger
Copy link
Member Author

@cybik the code removed here was only used in the Mono runtime and only helped when loading assemblies with mismatched casing, not for general System.IO.* usage (which is probably the more important use case). To implement that you'd need to change the pal_io.c code like what was done #35299.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants