Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraries][Android] Reenable System.Collections.Immutable Tests #56988

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 6, 2021

Fixes #50579

@mdh1418 mdh1418 requested a review from steveisok August 6, 2021 15:30
@ghost
Copy link

ghost commented Aug 6, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50579

Author: mdh1418
Assignees: -
Labels:

area-System.Collections

Milestone: -

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 9, 2021

The failures in runtime-staging are unrelated
#57010, a flakey System.Diagnostics.DiagnosticSource.Tests, some System.TypeInitializationException : The type initializer for 'System.Drawing.Printing.PrintingServices' threw an exception.\n---- System.TypeInitializationException : The type initializer for 'System.Drawing.Printing.LibcupsNative' threw an exception.\n-------- System.PlatformNotSupportedException : System.Drawing.Common is not supported on non-Windows platforms. See https://aka.ms/systemdrawingnonwindows for more information., and a few System.NotSupportedException : Support for UTF-7 is disabled. See https://aka.ms/dotnet-warnings/SYSLIB0001 for more information.
Will create an issue targeting net 7.0 to skip the flakes

Checking the results of the build test runs, both System.Collections.Immutable.Tests.ImmutableSortedDictionaryTest.Indexer_KeyNotFoundException_ContainsKeyInMessage and
System.Collections.Immutable.Tests.ImmutableDictionaryTest.Indexer_KeyNotFoundException_ContainsKeyInMessage pass, and System.Collections.Immutable.Tests.ImmutableArrayTest.IStructuralEquatableGetHashCode has no member data, so it is not ran.

@mdh1418 mdh1418 merged commit a3bd6d4 into dotnet:main Aug 9, 2021
@mdh1418 mdh1418 deleted the reenable_system_collections_immutable_android_tests branch August 9, 2021 17:33
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Collections.Immutable.Tests fails on Android
3 participants