-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetGenerationBounds under USE_REGIONS #57101
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsDo not merge, this is currently a work-in-progress.
|
a22ea0d
to
31d7bbf
Compare
31d7bbf
to
212128e
Compare
212128e
to
678175d
Compare
d384b9a
to
a39f5b2
Compare
I haven't really looked at the changes in proftoeeinterfaceimpl.cpp, I'll defer to @davmason. |
e832f3d
to
365a2f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the minor things I made comments on, otherwise looks good to me. Thanks Andrew!
43020c6
to
9aaba6d
Compare
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1174937983 |
@cshung backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: DiagAddNewRegion prototype
Applying: Updating the table directly under a lock
error: sha1 information is lacking or useless (src/coreclr/gc/gc.cpp).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Updating the table directly under a lock
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
Fixes #55965.