Annotate unsupported APIs in System.Diagnostics.Process #57120
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process Issue Detailsfixes #57090
|
| @@ -72,9 +72,5 @@ internal static void ThrowIfRemoteMachine(string machineName) | |||
| throw new PlatformNotSupportedException(SR.RemoteMachinesNotSupported); | |||
| } | |||
| } | |||
| public static IntPtr GetMainWindowHandle(int processId) | |||
There was a problem hiding this comment.
as pointed by @buyaa-n in #57090 (comment) it turned out to be dead code
| @@ -528,6 +528,8 @@ public string ProcessName | |||
| /// </devdoc> | |||
| public IntPtr ProcessorAffinity | |||
| { | |||
| [SupportedOSPlatform("windows")] | |||
| [SupportedOSPlatform("linux")] | |||
There was a problem hiding this comment.
Windows and Linux support it, everything else does not.
| @@ -88,6 +88,9 @@ public bool PriorityBoostEnabled | |||
| /// </devdoc> | |||
| public ThreadPriorityLevel PriorityLevel | |||
| { | |||
| [SupportedOSPlatform("windows")] | |||
| [SupportedOSPlatform("linux")] | |||
| [SupportedOSPlatform("freebsd")] | |||
There was a problem hiding this comment.
Windows, Linux and FreeBSD support it, everything else does not.
…e simply might not need it" This reverts commit 48bbece.
src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I concur with @stephentoub that property annotations should be on the property instead of the accessors, but otherwise approved.
I'm glad to see this get done.
|
Hello @adamsitnik! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Ah, I overlooked that the getter had different annotations than the setter. Looks good. |
ghost
locked as resolved and limited conversation to collaborators
fixes #57090