Make sure rid specific libs projs get packaged #57193
Conversation
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsMake sure rid specific libs projs get packaged … RID specific runtime.*.runtime.native.System.IO.Ports projects weren't Also updating the NoTargets Sdk to clean the rid specific package up. Moving the GeneratePackageOnBuild logic into a props file and set it to Remove the GeneratePackage property … That property was intended to enabled incremental servicing but with
|
| </PropertyGroup> | ||
|
|
||
| <!-- Remove when https://github.com/NuGet/Home/issues/10405 is implemented and consumed. --> | ||
| <Target Name="ErrorForMissingPackageDescription" |
There was a problem hiding this comment.
Also removing this block as it didn't work anymore for the NuGet pack as PackageDescription is always set to a default value.
ViktorHofer
force-pushed
the
PkgNativePackaging
branch
from
f33e00f
to
97e83f5
Compare
RID specific runtime.*.runtime.native.System.IO.Ports projects weren't packaged because the GeneratePackageOnBuild property wasn't set to true for them. The property was only true during an allconfigurations build. As these projects are only built outside of an allconfigurations build, the GeneratePackageOnBuild property needs to account for such as well. Also updating the NoTargets Sdk to clean the rid specific package up. Moving the GeneratePackageOnBuild logic into a props file and set it to false during servicing (or runtimelab) so that devs can set the property during servicing directly in the project file if a project should be packaged.
That property was intended to enabled incremental servicing but with now using the NuGet Pack task we can just make use of the publicl available GeneratePackageOnBuild property.
ViktorHofer
force-pushed
the
PkgNativePackaging
branch
from
97e83f5
to
2b74f1f
Compare
|
Formatting job failure: #57196 |
|
runtime (Libraries Test Run release coreclr windows x86 Debug) failure is #57187 |
ghost
locked as resolved and limited conversation to collaborators
Make sure rid specific libs projs get packaged …
RID specific runtime.*.runtime.native.System.IO.Ports projects weren't
packaged because the GeneratePackageOnBuild property wasn't set to true
for them. The property was only true during an allconfigurations build.
As these projects are only built outside of an allconfigurations build,
the GeneratePackageOnBuild property needs to account for such as well.
Also updating the NoTargets Sdk to clean the rid specific package up.
Moving the GeneratePackageOnBuild logic into a props file and set it to
false during servicing (or runtimelab) so that devs can set the property
during servicing directly in the project file if a project should be
packaged.
Remove the GeneratePackage property …
That property was intended to enabled incremental servicing but with
now using the NuGet Pack task we can just make use of the publicly
available GeneratePackageOnBuild property.