Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinned compiler version #57585

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Update pinned compiler version #57585

merged 3 commits into from
Aug 19, 2021

Conversation

stephentoub
Copy link
Member

The version that flows in automatically appears to still be old. We need to fix that, but in the meantime, we're a month out of date on the compiler.

@stephentoub stephentoub added this to the 6.0.0 milestone Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

The version that flows in automatically appears to still be old. We need to fix that, but in the meantime, we're a month out of date on the compiler.

Author: stephentoub
Assignees: -
Labels:

area-Infrastructure

Milestone: 6.0.0

@ViktorHofer
Copy link
Member

The update looks good but CI is failing.

@stephentoub
Copy link
Member Author

Yes, there's a new error being issued by the compiler around our use of nint/nuint. I'm following up.

@stephentoub
Copy link
Member Author

I suppressed the new warnings. I spoke with @jaredpar, and while they're "by design", I personally think the design is overaggressive bordering on erroneous and should be pulled back in scope. He's going to follow-up. For reference, it's now warning whenever you do things like typeof(nint) and typeof(List<object?>).

@akoeplinger
Copy link
Member

There's one more error:

src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs(3459,32): error CS8969: (NETCORE_ENGINEERING_TELEMETRY=Build) Type 'dynamic[]' cannot be used in this context because it cannot be represented in metadata.

@ViktorHofer
Copy link
Member

Unhandled exception. System.AggregateException: One or more errors occurred. (Code generation failed for method '[BasicTestWithMcj]BasicTest.Main()') (Code generation failed for method '[BasicTestWithMcj]BasicTest+<>c__DisplayClass2_0.<Main>b__4()')

is that concerning?

@stephentoub
Copy link
Member Author

The real error is here:

System.MissingMethodException: Method not found: 'Void System.Diagnostics.Debug.Assert(Boolean, AssertInterpolatedStringHandler)'

This suggests the assembly is somehow running against a slightly old corelib; the signature of that method was updated yesterday to accept a ref AssertInterpolatedStringHandler instead of AssertInterpolatedStringHandler. It looks like I messed up yesterday and merged #57536 without noticing that some of the red was real; mea culpa.

@davidwrighton?

@jkoritzinsky
Copy link
Member

I think the solution is to update the SDK we build against to one with your breaking API change.

@ViktorHofer
Copy link
Member

I think the solution is to update the SDK we build against to one with your breaking API change.

There are no plans to upgrade the SDK to an unsigned build again unless it's strictly necessary which would require Tactics approval.

@jkoritzinsky
Copy link
Member

Another option would be to lower the LangVersion of crossgen2 and its respective dependencies so the interpolated string builder overload isn’t picked, but I don’t know if we have a Roslyn compiler with that fix.

@jkoritzinsky
Copy link
Member

Or it looks like #57650 should fix the test failures.

The version that flows in automatically appears to still be old.  We need to fix that, but in the meantime, we're a month out of date on the compiler.
@stephentoub stephentoub merged commit 9ec6a20 into main Aug 19, 2021
@stephentoub stephentoub deleted the stephentoub-updatecompiler branch August 19, 2021 00:08
@stephentoub
Copy link
Member Author

/backport to release/6.0

@stephentoub
Copy link
Member Author

/backport to release/6.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1147169213

@github-actions
Copy link
Contributor

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1147169460

@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants