Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Fix Debug.Assert use of string interpolation in crossgen2 #57667

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 18, 2021

Backport of #57650 to release/6.0

/cc @stephentoub

Customer Impact

No customer impact. Testing of debug builds of crossgen2 is currently broken due to building against a live ref assembly of System.Runtime that includes an API change but then executing against an older version of Corelib that lacks that change.

Testing

CI

Risk

Nothing to speak of.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a cr and once the ci is green we can merge.

@stephentoub
Copy link
Member

windows arm64 checked failure is our old friend #11063.

@stephentoub stephentoub merged commit 0c015ec into release/6.0 Aug 18, 2021
@stephentoub stephentoub deleted the backport/pr-57650-to-release/6.0 branch August 18, 2021 19:37
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants