Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify mobile HttpClientHandler source files #57766

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

akoeplinger
Copy link
Member

They're 99% identical so we can just use one .cs file with ifdefs instead. This reduces the chance of missing one of the files when a new method is added.

They're 99% identical so we can just use one .cs file with ifdefs instead.
@ghost
Copy link

ghost commented Aug 19, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

They're 99% identical so we can just use one .cs file with ifdefs instead. This reduces the chance of missing one of the files when a new method is added.

Author: akoeplinger
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@karelz karelz added this to the 7.0.0 milestone Aug 20, 2021
@karelz karelz added os-android os-ios Apple iOS os-tvos Apple tvOS labels Aug 24, 2021
@ghost
Copy link

ghost commented Aug 24, 2021

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

They're 99% identical so we can just use one .cs file with ifdefs instead. This reduces the chance of missing one of the files when a new method is added.

Author: akoeplinger
Assignees: -
Labels:

area-System.Net.Http, os-android, os-ios, os-tvos

Milestone: 7.0.0

@akoeplinger akoeplinger merged commit f27372c into dotnet:main Aug 24, 2021
@akoeplinger akoeplinger deleted the simplify-httpclienthandler branch August 24, 2021 15:00
mdh1418 pushed a commit that referenced this pull request Sep 3, 2021
They're 99% identical so we can just use one .cs file with ifdefs instead. This reduces the chance of missing one of the files when a new method is added.
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants