Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix madeChanges in fgInline #57782

Merged
merged 9 commits into from
Aug 26, 2021
Merged

Fix madeChanges in fgInline #57782

merged 9 commits into from
Aug 26, 2021

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 19, 2021

Fixes #57775

fgUpdateInlineReturnExpressionPlaceHolder and fgLateDevirtualization didn't report back to fgInline that they changed something (or not).

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 19, 2021
@ghost
Copy link

ghost commented Aug 19, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #57775

fgUpdateInlineReturnExpressionPlaceHolder and fgLateDevirtualization didn't report back to fgInline that they changed something (or not).

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Aug 19, 2021
@EgorBo
Copy link
Member Author

EgorBo commented Aug 19, 2021

@JulieLeeMSFT this issue doesn't affect codegen, only fires in Checked builds so doesn't need to be in 6.0 milestone

@EgorBo EgorBo modified the milestones: 6.0.0, 7.0.0 Aug 19, 2021
@EgorBo
Copy link
Member Author

EgorBo commented Aug 20, 2021

@dotnet/jit-contrib @jakobbotsch PTAL

@EgorBo EgorBo merged commit a2f5da6 into dotnet:main Aug 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'm_compGenTreeID == m_compiler->compGenTreeID'
3 participants