Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Microsoft.DotNet.PackageValidation with Microsoft.DotNet.Compatibility Package #57783

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Aug 19, 2021

Added it as a darc dependency as well

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you update the darc subscriptions for both branches.

@ViktorHofer
Copy link
Member

.packages/microsoft.dotnet.compatibility/1.0.0-rc.2.21419.17/build/Microsoft.NET.Compatibility.Common.targets(26,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.Compatibility.ValidatePackage" task failed unexpectedly.
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

File name: 'Microsoft.CodeAnalysis, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
 ---> System.IO.FileNotFoundException: Could not load file or assembly '/__w/1/s/src/libraries/System.Runtime.Experimental/ref/bincore/Microsoft.CodeAnalysis.dll'. The system cannot find the file specified.

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 20, 2021

That change is already in the branch you are targeting: ba8967d. You just want to force CI to merge and rerun.

@Anipik
Copy link
Contributor Author

Anipik commented Aug 20, 2021

That change is already in the branch you are targeting: ba8967d.

yep saw that after commenting :P

You just want to force CI to merge and rerun.

does this mean reruning the entire thing ?

@ViktorHofer
Copy link
Member

does this mean reruning the entire thing ?

Yes. Closing, waiting a min and reopening the PR handles that.

@Anipik Anipik merged commit 91406a1 into dotnet:release/6.0 Aug 21, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2021
@Anipik Anipik deleted the automate6 branch November 10, 2021 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants