-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Enable win registry install location for all architectures #57851
Merged
jeffschwMSFT
merged 6 commits into
release/6.0
from
backport/pr-54698-to-release/6.0-rc1
Aug 31, 2021
Merged
[release/6.0] Enable win registry install location for all architectures #57851
jeffschwMSFT
merged 6 commits into
release/6.0
from
backport/pr-54698-to-release/6.0-rc1
Aug 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
runtime (Libraries Test Run release mono_interpreter Linux x64 Debug) is #48441 |
mateoatr
approved these changes
Aug 25, 2021
agocke
changed the title
[release/6.0-rc1] Enable win registry install location for all architectures
[release/6.0] Enable win registry install location for all architectures
Aug 25, 2021
jeffschwMSFT
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Once we have a green ci we can merge.
jeffschwMSFT
removed
the
Servicing-consider
Issue for next servicing release review
label
Aug 27, 2021
ghost
locked as resolved and limited conversation to collaborators
Oct 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #54698 to release/6.0
/cc @agocke @mateoatr
Customer Impact
Supports running x64 emulated runtimes on Windows ARM64 machines. Without this change, ARM64 apphosts will not be able to find the install location for the ARM64 runtime and will fail to run.
Testing
Manual verification
Risk
Low