Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-rc1] Fixed StreamPipeReader.CopyToAsync #57966

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2021

Backport of #57943 to release/6.0-rc1

/cc @davidfowl

Customer Impact

We introduced a regression in StreamPipeReader when doing performance optimizations in .NET 6. This could lead to silent corruption of data when using the CopyToAsync method.

Testing

Unit testing.

Risk

Very Low.

…unt when copying buffered data. This handles the case where ReadAsync has consumed a partial segment and then the same PipeReader instance is used to copy to a Stream and PipeWriter. - Added tests
@davidfowl
Copy link
Member

davidfowl commented Aug 24, 2021

cc @danmoseley this was servicing approved

@danmoseley danmoseley merged commit 2170911 into release/6.0-rc1 Aug 24, 2021
@danmoseley danmoseley deleted the backport/pr-57943-to-release/6.0-rc1 branch August 24, 2021 16:17
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants